Skip to content

fix(native): Suggest release build#2810

Merged
bruno-garcia merged 2 commits into
masterfrom
fix/native-release
Feb 3, 2021
Merged

fix(native): Suggest release build#2810
bruno-garcia merged 2 commits into
masterfrom
fix/native-release

Conversation

@bruno-garcia

@bruno-garcia bruno-garcia commented Dec 27, 2020

Copy link
Copy Markdown
Member

On Windows it builds in Debug mode by default.

See also:

#439
#442

@vercel

vercel Bot commented Dec 27, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/b7glpqjp8/sentry.dev
✅ Preview: https://sentry-docs-git-fix-native-release.sentry.dev

@bruno-garcia

Copy link
Copy Markdown
Member Author

/cc @Mixaill

@jan-auer jan-auer requested review from Swatinem and removed request for jan-auer January 3, 2021 14:56
@jan-auer

jan-auer commented Jan 3, 2021

Copy link
Copy Markdown
Member

Re-assigning this. @Swatinem there's probably more we could be updating in the documentation from the readme. Particularly, builds, backends and configuration options have extensive info in the README that should rather go in docs.

cmake -B build -D SENTRY_BACKEND=crashpad --config RelWithDebInfo
# build the project
cmake --build build --parallel
cmake --build build --config RelWithDebInfo --parallel

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also re-generate the file tree? now that we install debug symbols properly? (or to check if we actually do)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you asking if the pdb gets copied over on install?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump?

@github-actions

github-actions Bot commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@bruno-garcia bruno-garcia merged commit 1b340a5 into master Feb 3, 2021
@bruno-garcia bruno-garcia deleted the fix/native-release branch February 3, 2021 23:46
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants