Skip to content

Conversation

@ueman
Copy link
Contributor

@ueman ueman commented Mar 22, 2021

This adds the migration guide for Sentry Dart and Flutter v5

@vercel
Copy link

vercel bot commented Mar 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/Hp5s16nk6DV4WBbV6MMLA85K6tre
✅ Preview: https://sentry-docs-git-fork-ueman-dart-flutter-v5.sentry.dev

@ueman
Copy link
Contributor Author

ueman commented Mar 22, 2021

Can we somehow merge #3244 and #3243 into this? Or do I have to do it manually?

@marandaneto marandaneto requested a review from a team March 22, 2021 10:25
@marandaneto
Copy link
Contributor

Can we somehow merge #3244 and #3243 into this? Or do I have to do it manually?

you could cherry-pick or target that PR to this branch.
another option would be, we just merge them all together, (aka keeping as it is)

@PeloWriter PeloWriter linked an issue Mar 22, 2021 that may be closed by this pull request
@ueman
Copy link
Contributor Author

ueman commented Mar 23, 2021

Should we add some notes on Dart's null safety?
Something like sentry now requires at least Dart 1.12 and Flutter 2.0.0 ?

@marandaneto
Copy link
Contributor

marandaneto commented Mar 23, 2021

Should we add some notes on Dart's null safety?
Something like sentry now requires at least Dart 1.12 and Flutter 2.0.0 ?

about Dart yes, good point, the Flutter requirement didn't change though

here we should likely need a note too: https://docs.sentry.io/platforms/dart/usage/advanced-usage/#requirements
also here https://docs.sentry.io/platforms/flutter/

maybe we add a:

<Note>

Sentry's Dart/Flutter SDK version 5.0.0 and above requires Dart 1.12.

</Note>

plus an entry to the migration page

@marandaneto
Copy link
Contributor

@ueman missing notes related to #3287 (comment) and good to go

Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@marandaneto marandaneto marked this pull request as ready for review March 31, 2021 08:54
@marandaneto marandaneto requested a review from a team as a code owner March 31, 2021 08:54
@marandaneto marandaneto enabled auto-merge (squash) March 31, 2021 09:19
@marandaneto marandaneto merged commit a648570 into getsentry:master Mar 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2021
@ueman ueman deleted the dart-flutter-v5 branch April 26, 2021 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration guide for Dart/Flutter

3 participants