Skip to content

Update Grouping Content#3776

Merged
PeloWriter merged 8 commits into
masterfrom
update/grouping-content
Jun 25, 2021
Merged

Update Grouping Content#3776
PeloWriter merged 8 commits into
masterfrom
update/grouping-content

Conversation

@PeloWriter

Copy link
Copy Markdown
Contributor

In preparation for future functionality, we're moving the grouping content into SDK-specific content and product content.

The SDK fingerprinting content now lives in Usage > SDK Fingerprinting. The data management content is now in product > Data Management > Issue Grouping. This also had the knock-on effect of removing a series of include folders that weren't really needed (as the product side doesn't currently support the use of include statements).

@PeloWriter PeloWriter requested a review from a team as a code owner June 22, 2021 21:40
@PeloWriter PeloWriter requested a review from a team June 22, 2021 21:40
@vercel

vercel Bot commented Jun 22, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/5Mhi3U5adwCSKGRiHLU6dhq2MAGR
✅ Preview: https://sentry-docs-git-update-grouping-content.sentry.dev

@PeloWriter PeloWriter requested review from jan-auer and removed request for a team June 22, 2021 21:40

@jan-auer jan-auer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document is called "Issue Grouping", so since we're moving it already, I'd also use issue-grouping in the URL rather than event-grouping.

@@ -1,10 +0,0 @@
```discover {tabTitle: Enhancement Rules}
# mark all functions in the std namespace to be outside the app
family:native stack.function:std::* -app

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm realizing that these examples are actually useful. I completely missed that we had these customized. Do you have an idea on where or how we can keep them? Maybe keep a tiny section in the platform docs, and then link to product docs for full detail?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, on the product side of the house, the include statements don't work as they do for platforms. For now, we can add more examples and hard code them. In future, with more tools support, we can enable platform-specific support/include statements on the product side of our content.

redirect_from:
- /data-management/rollups/
- /learn/rollups/
- /data-management/event-grouping/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this redirect from the platform pages, or is that what it does?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the location in which it used to reside.

@PeloWriter PeloWriter merged commit a1a5f3b into master Jun 25, 2021
@PeloWriter PeloWriter deleted the update/grouping-content branch June 25, 2021 16:00
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants