Skip to content

Add Linking guidelines#3872

Merged
PeloWriter merged 9 commits into
masterfrom
add/linking-guidelines
Jul 13, 2021
Merged

Add Linking guidelines#3872
PeloWriter merged 9 commits into
masterfrom
add/linking-guidelines

Conversation

@PeloWriter

Copy link
Copy Markdown
Contributor

No description provided.

@PeloWriter PeloWriter requested a review from imatwawana July 13, 2021 21:45
@vercel

vercel Bot commented Jul 13, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/7SnRTYNBUbx1pbJ7sB8bf5no2no2
✅ Preview: https://sentry-docs-git-add-linking-guidelines.sentry.dev

@imatwawana imatwawana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RH sidebar fix is the only imperative change. Other than that, this is great! Very clear.

Comment thread src/docs/contributing/linking.mdx
Comment thread src/docs/contributing/linking.mdx Outdated
Comment thread src/docs/contributing/linking.mdx Outdated
Comment thread src/docs/contributing/linking.mdx
Comment thread src/docs/contributing/linking.mdx Outdated
Comment thread src/docs/contributing/linking.mdx Outdated
Comment thread src/docs/contributing/linking.mdx
Comment thread src/docs/contributing/linking.mdx Outdated
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
PeloWriter and others added 7 commits July 13, 2021 15:05
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@PeloWriter

Copy link
Copy Markdown
Contributor Author

Thanks for being a second set of eyes on this, @imatwawana :)

@PeloWriter PeloWriter enabled auto-merge (squash) July 13, 2021 22:06
@PeloWriter PeloWriter merged commit 8f9438a into master Jul 13, 2021
@PeloWriter PeloWriter deleted the add/linking-guidelines branch July 13, 2021 22:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants