fix(react): Update React Router v4/v5 to make paramaterization more clear#5471
Merged
AbhiPrasad merged 3 commits intomasterfrom Aug 31, 2022
Merged
fix(react): Update React Router v4/v5 to make paramaterization more clear#5471AbhiPrasad merged 3 commits intomasterfrom
AbhiPrasad merged 3 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
imatwawana
approved these changes
Aug 31, 2022
Contributor
imatwawana
left a comment
imatwawana
left a comment
There was a problem hiding this comment.
Made some wording edits, but otherwise looks good!
src/platforms/javascript/guides/react/configuration/integrations/react-router.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/react/configuration/integrations/react-router.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/react/configuration/integrations/react-router.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/react/configuration/integrations/react-router.mdx
Outdated
Show resolved
Hide resolved
k-fish
approved these changes
Aug 31, 2022
…ns/react-router.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make sure we prevent possible mis-configurations with the React Router v4/v5 integration, this PR updates our docs around it. We first move the usage of
withSentryRoutinghigher up, and encourage it as the default approach to use for paramaterization. We then move down the route config option below that, and offer it as a way for users to define paths outside of the usage ofwithSentryRouting.