Skip to content

feat(replays): Document the new search properties available for the Replay DOM Search feature#6465

Merged
cmanallen merged 11 commits into
masterfrom
ryan953/6464-replay-dom-search-properties
Apr 18, 2023
Merged

feat(replays): Document the new search properties available for the Replay DOM Search feature#6465
cmanallen merged 11 commits into
masterfrom
ryan953/6464-replay-dom-search-properties

Conversation

@ryan953

@ryan953 ryan953 commented Mar 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@vercel

vercel Bot commented Mar 13, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 7:04pm

@ryan953 ryan953 marked this pull request as draft March 13, 2023 23:00
@ryan953 ryan953 requested a review from a team March 13, 2023 23:00
@ryan953 ryan953 mentioned this pull request Mar 13, 2023
Merged
@lizokm lizokm assigned lizokm and unassigned lizokm Mar 14, 2023
@lizokm lizokm self-requested a review March 14, 2023 16:56
@lizokm

lizokm commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

Hi hi! @ryan953 Would you like me to take a look at this while it's still in draft or should I hold off for now?

billyvg added a commit to getsentry/sentry that referenced this pull request Mar 30, 2023
@ryan953 @billyvg
feat(replays): Add auto-complete for the new fields that related to D…
534fc20 
…OM Search (#45744)

Related to getsentry/sentry-docs#6465
Related to #45763

Fixes #45741

---------

Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Co-authored-by: Billy Vong <billy@sentry.io>
@github-actions

github-actions Bot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@ryan953 ryan953 marked this pull request as ready for review April 7, 2023 12:38
cmanallen
cmanallen requested changes Apr 10, 2023
View reviewed changes
Comment thread src/docs/product/sentry-basics/search/searchable-properties.mdx Outdated
@ryan953

ryan953 commented Apr 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@cmanallen We're also changing the prefix to be click.* correct?

edit: yes we are. See
getsentry/sentry#47184
getsentry/sentry#47162

@ryan953 ryan953 requested a review from cmanallen April 12, 2023 04:26
@ryan953

ryan953 commented Apr 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@lizokm I think this is ready for your eyes. We've settled on the list of fields, no new fields will be added so we can describe what we have.

@cmanallen

cmanallen commented Apr 13, 2023

Copy link
Copy Markdown
Member

Related: getsentry/sentry#45524

@bruno-garcia bruno-garcia mentioned this pull request Apr 18, 2023
Closed
lizokm
lizokm approved these changes Apr 18, 2023
View reviewed changes

@lizokm lizokm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small tweaks.

Comment thread src/docs/product/sentry-basics/search/searchable-properties.mdx Outdated
@cmanallen @lizokm
Update src/docs/product/sentry-basics/search/searchable-properties.mdx
e39bcc5 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@cmanallen cmanallen enabled auto-merge (squash) April 18, 2023 18:50
@cmanallen cmanallen disabled auto-merge April 18, 2023 20:18
@cmanallen cmanallen merged commit d484063 into master Apr 18, 2023
@cmanallen cmanallen deleted the ryan953/6464-replay-dom-search-properties branch April 18, 2023 20:21
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@cmanallen cmanallen cmanallen approved these changes

+1 more reviewer

@lizokm lizokm lizokm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update [searchable properties docs](https://docs.sentry.io/product/sentry-basics/search/searchable-properties/)

4 participants

@ryan953 @lizokm @cmanallen @bruno-garcia