Replace Task default with Task.CompletedTask in tests#1259
Merged
Conversation
SimonCropp
requested review from
bruno-garcia and
lucas-zimerman
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1259 +/- ##
=======================================
Coverage 81.57% 81.57%
=======================================
Files 212 212
Lines 7024 7024
Branches 1463 1463
=======================================
Hits 5730 5730
Misses 846 846
Partials 448 448 Continue to review full report at Codecov.
|
Member
|
Good find. At some point we had ValueTask's so that must be left overs from those days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog.
noticed via updating Roslynator.Analyzers to Version 3.2.2 #1257