Update console sample#2317
Merged
Merged
Conversation
Closed
Contributor
|
Contributor
Author
|
Also made a few minor changes to the "customized" sample (and the copy of it currently used by profiling). This was just to get the build passing. We will need to review those samples with more scrutiny to get them in better shape later. |
SeanFeldman
approved these changes
Apr 20, 2023
jamescrosswell
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the basic console sample to cover the key features we think most users will want to use.
Also uses an MSBuild-based approach to setting the default DSN for sample projects. This allows a
SENTRY_DSNenvironment variable to override the default without having to change any code. We'll apply the same technique to the other samples as we clean them up one at a time.See comments inline.
#skip-changelog