Capture event when unoptimized asm#365
Closed
bruno-garcia wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 93.33% 92.26% -1.08%
==========================================
Files 117 118 +1
Lines 2806 2843 +37
==========================================
+ Hits 2619 2623 +4
- Misses 187 220 +33
Continue to review full report at Codecov.
|
Contributor
|
Can be closed now? 😉 |
Member
Author
|
There's a analyzer for this now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I first thought of this feature when I found out that the old Sentry SDK had debug builds published to nuget.org.
This is happening because default of
dotnet packis Debug. One needs to set-c Releaseto get the optmized assemblies.Since this came again on twitter, I decided to open up a draft at least to discuss.
Resolves #364