Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Jan 7, 2026

Note

#skip-changelog (merges to #4781)

@linear
Copy link

linear bot commented Jan 7, 2026

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.81%. Comparing base (290cf51) to head (a9f3610).
⚠️ Report is 12 commits behind head on deps/modules/sentry-cocoa.properties.

Additional details and impacted files
@@                           Coverage Diff                            @@
##           deps/modules/sentry-cocoa.properties    #4830      +/-   ##
========================================================================
+ Coverage                                 73.79%   73.81%   +0.02%     
========================================================================
  Files                                       483      483              
  Lines                                     17551    17559       +8     
  Branches                                   3461     3461              
========================================================================
+ Hits                                      12952    12962      +10     
+ Misses                                     3746     3744       -2     
  Partials                                    853      853              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-cocoa.properties branch 2 times, most recently from 509f0c9 to fe091a7 Compare January 15, 2026 03:29
@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-cocoa.properties branch 2 times, most recently from 76b917d to 1c85ec4 Compare January 21, 2026 03:29
@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-cocoa.properties branch from 1c85ec4 to dc6c357 Compare January 22, 2026 03:30
@jpnurmi jpnurmi force-pushed the deps/sentry-cocoa-9 branch from c56e53c to dd04bd0 Compare January 22, 2026 07:42
@jpnurmi jpnurmi force-pushed the deps/sentry-cocoa-9 branch from dd04bd0 to cf215b1 Compare January 22, 2026 08:06
It has multiple conflicting NSNumber[] constructors for boolean,
integer, and float arrays:

error CS0111: Type 'SentryAttribute' already defines a member called 'Constructor' with the same parameter types
@jpnurmi jpnurmi changed the title WIP: Update bindings for Cocoa SDK v9 Update bindings for Cocoa SDK v9 Jan 22, 2026
@jpnurmi jpnurmi marked this pull request as ready for review January 22, 2026 12:48
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - thanks @jpnurmi !

@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-cocoa.properties branch from dc6c357 to f4ed890 Compare January 23, 2026 03:29
@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-cocoa.properties branch from f4ed890 to 117130f Compare January 24, 2026 03:28
@jamescrosswell jamescrosswell self-requested a review January 25, 2026 23:08
Prevent EnableAppHangTrackingV2=false from overriding
EnableAppHangTracking=true by only applying true values
from the obsolete V2 property. This maintains backward
compatibility while fixing the silent disable issue.
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

jpnurmi and others added 3 commits January 26, 2026 10:22
Combine EnableAppHangTracking and EnableAppHangTrackingV2 with OR
logic when initializing the native SDK. This fixes the config order
issue where setting both options could unexpectedly disable tracking,
and ensures backward compatibility for users of the obsolete V2 option.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-cocoa.properties branch from 117130f to 4ff6050 Compare January 27, 2026 03:30
@jpnurmi jpnurmi merged commit 8a6509a into deps/modules/sentry-cocoa.properties Jan 28, 2026
31 checks passed
@jpnurmi jpnurmi deleted the deps/sentry-cocoa-9 branch January 28, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants