-
-
Notifications
You must be signed in to change notification settings - Fork 229
Update bindings for Cocoa SDK v9 #4830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bindings for Cocoa SDK v9 #4830
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## deps/modules/sentry-cocoa.properties #4830 +/- ##
========================================================================
+ Coverage 73.79% 73.81% +0.02%
========================================================================
Files 483 483
Lines 17551 17559 +8
Branches 3461 3461
========================================================================
+ Hits 12952 12962 +10
+ Misses 3746 3744 -2
Partials 853 853 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
509f0c9 to
fe091a7
Compare
76b917d to
1c85ec4
Compare
1c85ec4 to
dc6c357
Compare
c56e53c to
dd04bd0
Compare
dd04bd0 to
cf215b1
Compare
It has multiple conflicting NSNumber[] constructors for boolean, integer, and float arrays: error CS0111: Type 'SentryAttribute' already defines a member called 'Constructor' with the same parameter types
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work - thanks @jpnurmi !
dc6c357 to
f4ed890
Compare
f4ed890 to
117130f
Compare
Prevent EnableAppHangTrackingV2=false from overriding EnableAppHangTracking=true by only applying true values from the obsolete V2 property. This maintains backward compatibility while fixing the silent disable issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This reverts commit e827eaf.
This partially reverts commit 66618f9.
Combine EnableAppHangTracking and EnableAppHangTrackingV2 with OR logic when initializing the native SDK. This fixes the config order issue where setting both options could unexpectedly disable tracking, and ensures backward compatibility for users of the obsolete V2 option. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
117130f to
4ff6050
Compare
8a6509a
into
deps/modules/sentry-cocoa.properties
Note
PrivatesHeader.handPrivateSentrySDKOnly.hwere moved fromPrivateHeaders/toHeaders/SentryOptions.enableAppHangTrackingV2was removed: chore: Remove hang tracker sdk v9 checks sentry-cocoa#6334SentryOptions.inAppExcludeswas removed: fix: Remove property that had no effect sentry-cocoa#6646PrivateSentrySDKOnly.getDebugImageswas removed: ref: Remove v9 checks for debug image provider sentry-cocoa#6454#skip-changelog (merges to #4781)