fix: CaptureFeedback now supports multiple attachments correctly#5077
Merged
jamescrosswell merged 3 commits intomainfrom Mar 30, 2026
Merged
fix: CaptureFeedback now supports multiple attachments correctly#5077jamescrosswell merged 3 commits intomainfrom
CaptureFeedback now supports multiple attachments correctly#5077jamescrosswell merged 3 commits intomainfrom
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
Features ✨
Fixes 🐛
Dependencies ⬆️Deps
Other
🤖 This preview updates automatically when you update the PR. |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5077 +/- ##
==========================================
- Coverage 74.00% 74.00% -0.01%
==========================================
Files 499 499
Lines 18066 18067 +1
Branches 3518 3519 +1
==========================================
Hits 13370 13370
- Misses 3837 3838 +1
Partials 859 859 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
It was just copied from the JS SDK which does have this restriction, but that's just a browser/JS thing, not a protocol thing so we should remove. |
Collaborator
|
Yeah I think when I first implemented it the protocol wouldn't accept more than one Attachment. We did discuss that and the server was changed - we just never circled back to address the SDK. Thanks @bitsandfoxes ! |
jamescrosswell
changed the title
CaptureFeedbackCaptureFeedback now supports multiple attachments correctly
3 tasks
irvinesunday
added a commit
to irvinesunday/Hali
that referenced
this pull request
Apr 8, 2026
Updated [Sentry.AspNetCore](https://github.com/getsentry/sentry-dotnet) from 6.3.0 to 6.3.1. <details> <summary>Release notes</summary> _Sourced from [Sentry.AspNetCore's releases](https://github.com/getsentry/sentry-dotnet/releases)._ ## 6.3.1 ### Fixes 🐛 - fix: Workaround FileNotFoundException on Android when recovering sessions by @jamescrosswell in [#5084](getsentry/sentry-dotnet#5084) - fix: `CaptureFeedback` now supports multiple attachments correctly by @bitsandfoxes in [#5077](getsentry/sentry-dotnet#5077) ### Dependencies ⬆️ #### Deps - chore(deps): update Native SDK to v0.13.5 by @github-actions in [#5119](getsentry/sentry-dotnet#5119) - chore(deps): update CLI to v3.3.5 by @github-actions in [#5093](getsentry/sentry-dotnet#5093) - chore(deps): update Native SDK to v0.13.4 by @github-actions in [#5081](getsentry/sentry-dotnet#5081) - chore(deps): update Java SDK to v8.37.1 by @github-actions in [#5071](getsentry/sentry-dotnet#5071) - chore(deps): update CLI to v3.3.4 by @github-actions in [#5068](getsentry/sentry-dotnet#5068) - chore(deps): update Java SDK to v8.37.0 by @github-actions in [#5069](getsentry/sentry-dotnet#5069) - chore(deps): update Cocoa SDK to v9.8.0 by @github-actions in [#5044](getsentry/sentry-dotnet#5044) - chore(deps): update Java SDK to v8.36.0 by @github-actions in [#5036](getsentry/sentry-dotnet#5036) - chore(deps): update epitaph to 0.1.1 by @github-actions in [#5036](getsentry/sentry-dotnet#5036) ### Other - chore: Update validate-pr workflow by @stephanie-anderson in [#5108](getsentry/sentry-dotnet#5108) - ci: fix workflows that always fail for fork PRs by @jamescrosswell in [#5065](getsentry/sentry-dotnet#5065) Commits viewable in [compare view](getsentry/sentry-dotnet@6.3.0...6.3.1). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on: #3981
I could not find any source, neither in the dev docs nor on Sentry, for the "only one attachment per feeedback" restriction. The envelop created from a feedback can hold as many attachments as any other and will get processed by Sentry accordingly.