ci: restore version bumping via craft preReleaseCommand#5261
Merged
Conversation
#skip-changelog Craft 2.26.6's built-in nuget auto-bumper looks for the `dotnet-setversion` CLI and, when not found, falls back to a "manual edit" heuristic that does not recognize `Directory.Build.props`. It downgrades the failure to a warn and lets prepare continue, so the `release: 6.6.0` commit only updated CHANGELOG.md and the resulting nupkg files were named `*.6.5.0.nupkg`. The repo's own scripts/bump-version.sh already rewrites <VersionPrefix> correctly. Wire it back in via craft's preReleaseCommand, as the warning in the prepare log recommends. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
#skip-changelog Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5261 +/- ##
==========================================
- Coverage 74.13% 74.09% -0.04%
==========================================
Files 508 508
Lines 18320 18320
Branches 3584 3584
==========================================
- Hits 13581 13575 -6
- Misses 3864 3872 +8
+ Partials 875 873 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dingsdax
approved these changes
May 28, 2026
jamescrosswell
added
the
skip-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5260
What happened
The
release: 6.6.0commit (0140be0) only modifiedCHANGELOG.md—<VersionPrefix>inDirectory.Build.propswas left at6.5.0. Every nupkg built in the publish step was therefore named*.6.5.0.nupkg, and that's what got attached to the6.6.0GitHub release (and pushed to NuGet).For comparison, the 6.5.0 release commit correctly bumped both
CHANGELOG.mdandDirectory.Build.props(6.4.1 → 6.5.0).Root cause
From the craft prepare log in run 26499066767:
Craft 2.26.6's built-in nuget auto-bumper looks for the
dotnet-setversionCLI, doesn't find it on the runner image, falls back to a "manual edit" heuristic that doesn't recognizeDirectory.Build.props, and downgrades the failure to a warning — so prepare carries on and commits/tags with the stale version.This regressed when #5206 bumped craft
minVersionto opt into theautoversioning strategy. Before that, the repo's ownscripts/bump-version.ps1was rewriting<VersionPrefix>via the older pre-release hook convention; the switch to craft-native auto-bump dropped that wiring.#skip-changelog