Skip to content

feat(metrics): support for Metrics#1018

Open
solnic wants to merge 1 commit intomasterfrom
954-sentry-metrics-for-elixir
Open

feat(metrics): support for Metrics#1018
solnic wants to merge 1 commit intomasterfrom
954-sentry-metrics-for-elixir

Conversation

@solnic
Copy link
Copy Markdown
Collaborator

@solnic solnic commented Mar 16, 2026

Adds support for Sentry Metrics via Sentry.Metrics. Uses the new TelemetryProcessor for batching and sending metrics.

Screenshot

image

Arc 2026-03-23 14 53 42

@solnic solnic linked an issue Mar 16, 2026 that may be closed by this pull request
@solnic solnic force-pushed the 954-sentry-metrics-for-elixir branch 3 times, most recently from 572dc4b to b65c9d4 Compare March 16, 2026 15:03
@solnic solnic changed the title wip(metrics): add Metrics support feat(metrics): support for Metrics Mar 16, 2026
@solnic solnic force-pushed the 954-sentry-metrics-for-elixir branch from b65c9d4 to 2484046 Compare March 23, 2026 13:19
@solnic solnic marked this pull request as ready for review March 23, 2026 15:28
cursor[bot]

This comment was marked as resolved.

@solnic solnic force-pushed the 954-sentry-metrics-for-elixir branch from f6f84bb to 681b34a Compare March 24, 2026 07:35
cursor[bot]

This comment was marked as resolved.

@solnic solnic force-pushed the 954-sentry-metrics-for-elixir branch from 681b34a to d33bc2b Compare March 24, 2026 07:41
@solnic solnic force-pushed the 954-sentry-metrics-for-elixir branch from d33bc2b to 2159c74 Compare March 24, 2026 09:26
@solnic solnic force-pushed the 954-sentry-metrics-for-elixir branch from 2159c74 to 8005347 Compare March 27, 2026 09:49
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.


[] ->
:ok
end
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing DSN guard in async metric sending path

Low Severity

The :none non-TelemetryProcessor path calls Transport.Sender.send_async(client, filtered_metric) without checking Config.dsn() first. The :sync path correctly guards with if Config.dsn() do before attempting to send. When DSN is nil and :metric is removed from telemetry_processor_categories, this path will attempt to send to a nil endpoint.

Additional Locations (1)
Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry Metrics for Elixir

1 participant