Open
Conversation
572dc4b to
b65c9d4
Compare
b65c9d4 to
2484046
Compare
f6f84bb to
681b34a
Compare
681b34a to
d33bc2b
Compare
d33bc2b to
2159c74
Compare
2159c74 to
8005347
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
|
||
| [] -> | ||
| :ok | ||
| end |
There was a problem hiding this comment.
Missing DSN guard in async metric sending path
Low Severity
The :none non-TelemetryProcessor path calls Transport.Sender.send_async(client, filtered_metric) without checking Config.dsn() first. The :sync path correctly guards with if Config.dsn() do before attempting to send. When DSN is nil and :metric is removed from telemetry_processor_categories, this path will attempt to send to a nil endpoint.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds support for Sentry Metrics via
Sentry.Metrics. Uses the newTelemetryProcessorfor batching and sending metrics.Screenshot