feat(test): add assert_sentry_metric/2 assertion helper#1042
Merged
Conversation
Add a dedicated assert_sentry_metric/2 helper that mirrors assert_sentry_log/3 for metrics. Uses find semantics so tests succeed even when multiple metrics are emitted together (a common pattern), and returns unmatched metrics to an inbox for subsequent assertions in the same test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
solnic
force-pushed
the
feat/assert-sentry-metric
branch
from
9300e43 to
59ff1c4
Compare
dingsdax
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dedicated assert_sentry_metric/2 helper that mirrors assert_sentry_log/3 for metrics. Uses find semantics so tests succeed even when multiple metrics are emitted together (a common pattern), and returns unmatched metrics to an inbox for subsequent assertions in the same test.