Scrub Cookies #254
Merged
Scrub Cookies #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeregrine
reviewed
Feb 15, 2018
lib/sentry/plug.ex
Outdated
|
|
||
| @spec default_cookie_scrubber(Plug.Conn.t()) :: map() | ||
| def default_cookie_scrubber(_conn) do | ||
| # Enum.into(conn.req_headers, %{}) |
There was a problem hiding this comment.
remove commented out code
| end | ||
|
|
||
| test "scrubs cookies" do | ||
| bypass = Bypass.open() |
There was a problem hiding this comment.
add a test with a custom scrubber
mitchellhenke
force-pushed
the
scrub-cookies
branch
3 times, most recently
from
663f8da to
b860c18
Compare
mitchellhenke
force-pushed
the
scrub-cookies
branch
from
b860c18 to
710e890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in that we should not be sending cookies, as there's no good default to prevent sending sensitive data.
By default, we won't send any, but will allow for users to override it with the
cookie_scrubberoption onSentry.PlugCloses #253