fix(oban): Handle @reboot cron schedule with timezone#981
Merged
whatyouhide merged 1 commit intogetsentry:masterfrom Jan 31, 2026
Merged
fix(oban): Handle @reboot cron schedule with timezone#981whatyouhide merged 1 commit intogetsentry:masterfrom
whatyouhide merged 1 commit intogetsentry:masterfrom
Conversation
Previously, Oban jobs using the @reboot schedule with a timezone set would crash the telemetry handler with a {badkey, schedule} error. This happened because: 1. @reboot correctly returns an empty schedule (can't be expressed as cron/interval) 2. The timezone was still being added to monitor_config 3. CheckIn.new/1 crashed trying to access the missing :schedule key The fix checks for an empty schedule first and returns nil (skipping check-in) before adding timezone or other monitor config options. This ensures @reboot jobs are gracefully skipped from Sentry cron monitoring, since they cannot be represented as a scheduled monitor. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
I wasn't sure what the linear id was. I pulled Elixir-30 out of the URL posted on the original issue in GH. |
whatyouhide
approved these changes
Jan 31, 2026
Collaborator
|
Nice, thank you @StephenTurley 🫶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Oban jobs using the @reboot schedule with a timezone set would crash the telemetry handler with a {badkey, schedule} error. This happened because:
Description
The fix checks for an empty schedule first and returns nil (skipping check-in) before adding timezone or other monitor config options. This ensures @reboot jobs are gracefully skipped from Sentry cron monitoring, since they cannot be represented as a scheduled monitor.
Issues
Reminders
feat:,fix:,ref:,meta:)