Skip to content

feat!: Send uint64 overflowing attributes as numbers for slog and logrus#1198

Merged
giortzisg merged 3 commits intomasterfrom
fix/handle-uint64-attr
Feb 20, 2026
Merged

feat!: Send uint64 overflowing attributes as numbers for slog and logrus#1198
giortzisg merged 3 commits intomasterfrom
fix/handle-uint64-attr

Conversation

@giortzisg
Copy link
Contributor

@giortzisg giortzisg commented Feb 12, 2026

Description

This PR changes the behavior of handling unsigned ints for the slog and logrus integrations. Previously if the value overflowed we converted the value (since relay does not currently support uint64). This runs the risk of having two different types for numbers or losing precision when converting to float64.

The recommended approach is to send the type as is and let relay log a message to the user that their value was dropped due to overflow.

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

  • Single entry: just write text
  • Multiple entries: use bullet points
  • Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

Changelog Entry

  • Send uint64 overflowing attributes as numbers.
    • The SDK was converting overflowing uint64 attributes to strings for slog and logrus integrations. To eliminate double types for these attributes, the SDK now sends the overflowing attribute as is, and lets the server handle the overflow appropriately.
    • It is expected that overflowing unsigned integers would now get dropped, instead of converted to strings.

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Semver Impact of This PR

🔴 Major (breaking changes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Breaking Changes 🛠

  • Add support for go 1.26 by giortzisg in #1193
    • bump minimum supported go version to 1.24
  • Send uint64 overflowing attributes as numbers. by giortzisg in #1198
    • The SDK was converting overflowing uint64 attributes to strings for slog and logrus integrations. To eliminate double types for these attributes, the SDK now sends the overflowing attribute as is, and lets the server handle the overflow appropriately.
    • It is expected that overflowing unsigned integers would now get dropped, instead of converted to strings.

New Features ✨

  • Log specific message for RequestEntityTooLarge by giortzisg in #1185

Bug Fixes 🐛

  • Ensure correct signal delivery on multi-client setups by giortzisg in #1190

Internal Changes 🔧

Deps

  • Bump golang.org/x/crypto to 0.48.0 by giortzisg in #1196
  • Use go1.24.0 by giortzisg in #1195
  • Bump github.com/gofiber/fiber/v2 from 2.52.9 to 2.52.11 in /fiber by dependabot in #1191
  • Bump getsentry/craft from 2.19.0 to 2.20.1 by dependabot in #1187

Other

  • Add omitzero and remove custom serialization by giortzisg in #1197
  • Rename Telemetry Processor components by giortzisg in #1186

🤖 This preview updates automatically when you update the PR.

@giortzisg giortzisg changed the title feat!: do not convert overflowing unsigned ints feat!: Send uint64 overflowing attributes as numbers for slog and logrus Feb 20, 2026
@giortzisg giortzisg merged commit e1e8ceb into master Feb 20, 2026
22 checks passed
@giortzisg giortzisg deleted the fix/handle-uint64-attr branch February 20, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments