Skip to content

fix(scope): use scoped client for request PII#1289

Merged
giortzisg merged 1 commit intomasterfrom
fix/request-pii-client-scope
Apr 28, 2026
Merged

fix(scope): use scoped client for request PII#1289
giortzisg merged 1 commit intomasterfrom
fix/request-pii-client-scope

Conversation

@giortzisg
Copy link
Copy Markdown
Contributor

@giortzisg giortzisg commented Apr 28, 2026

Summary

  • thread the effective decision through request construction
  • build event requests from the client handling the current event instead of the global hub
  • add a regression test that covers mixed-client PII settings on the same process

Resolves SDK-1188

Build request payloads from the client handling the current event
instead of consulting the global hub. This keeps SendDefaultPII
decisions aligned with request-scoped clients and avoids leaking
cookies, headers, or remote IP data across client boundaries.

Co-Authored-By: GPT-5 <noreply@example.com>
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 28, 2026

@giortzisg giortzisg requested a review from Litarnus April 28, 2026 11:59
@giortzisg giortzisg merged commit c8ea578 into master Apr 28, 2026
16 checks passed
@giortzisg giortzisg deleted the fix/request-pii-client-scope branch April 28, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants