Empty DSN on Spring configuration fails disable Sentry

[bruno-garcia]

My app. fails to start when passing sentry.dsn=${SENTRY_DSN:""} or sentry.dsn=${SENTRY_DSN:}, using 3.x

Failed to instantiate [io.sentry.IHub]: Factory method 'sentryHub' threw exception; nested exception is 
io.sentry.InvalidDsnException: java.net.URISyntaxException: Illegal character in path at index 0: ""
how to disable it locally?

From this comment: #574 (comment)

[jenni]

thanks @bruno-garcia !
I am passing sentry.dsn=${SENTRY_DSN:https://key@host/id} as a workaround.
also, would gladly pick this issue as a first contribution if that's ok?

[marandaneto]

@jenni sure, go for it.

just a quick question: are you using an integration? logback, log4j2 or spring?
how are you setting up your configurations? eg sentry.properties, application.properties?

have you tried as simple as sentry.dsn= ? without the ${SENTRY_DSN:something}

[jenni]

@marandaneto
I've just tried again
it now works with ${SENTRY_DSN:} (I might've had some wrong or cached config)
but not with ${SENTRY_DSN:""}, which I'm assuming it's expected since the value of dsn is literally the chars "" in this case

my config:

application.properties

# Sentry v3 config
sentry.release=${SENTRY_RELEASE}
sentry.environment=${SENTRY_ENVIRONMENT}
sentry.dsn=${SENTRY_DSN:""}
sentry.logging.minimum-event-level=error
sentry.logging.minimum-breadcrumb-level=debug

build.gradle

implementation 'io.sentry:sentry-spring-boot-starter:3.2.0'
implementation 'io.sentry:sentry-logback:3.2.0'

[maciejwalkowiak]

Thanks @jenni for taking a look. I have also double checked it and as you said, sentry.dsn=${SENTRY_DSN:} works as expected.

Sample repo: https://github.com/maciej-scratches/sentry-empty-dsn