Auto instrumentation doesn't work + JDBC metrics doesn't send

[NDruce]

Integration

sentry-spring-boot-starter

Java Version

17

Version

6.0.0

Steps to Reproduce

Followed official tutorials, rereading them ~30 times, searching a lot of Internet for week, and now I decided to create issue.

I have all Maven dependencies, Sentry Exceptions are successfully sending (but settings in application.properties wasn't work so I wasted 1-2 days to make just work anything). But no one Spring Boot MVC requests was traced:
https://docs.sentry.io/platforms/java/guides/spring-boot/performance/instrumentation/automatic-instrumentation/
(all written in instruction I was made and this Bean was told me via System.out.println that it was called). But no Transactions in Sentry. My sentry.properties config:

dsn=https://**********@**************.ingest.sentry.io/**********
traces-sample-rate=1.0
sample-rate=1.0
debug=true
enable-tracing=true
enable-user-interaction-tracing=true
#exception-resolver-order=-2147483647
send-default-pii=true
max-request-body-size=medium
logging.minimum-event-level=info
logging.minimum-breadcrumb-level=debug
max-breadcrumbs=150
#in-app-includes="com.companyname.application"

I made custom instrumentation:
https://hastebin.com/uwulijeput.php

But I think it's kind of crutch and just a desperation, because no other (and more correct) way of tracing requests doesn’t want to work, and therefore I write the entire implementation myself...

With my instrumentation I have no ability to get all detailed stack trace of calling functions where each submethod call is new child span. And I forced to manually declare spans for each submethod in code.

I just want to understand why automatic instrumentation don't working. Because now I have to take time for write each separate span for a lot of method calls.
When with automatic instrumentation, having code like

public void checkout() {
    paymentServiceCall();
    anyOtherMethod();
}

public void paymentServiceCall() {
    runFraudScorer();
    withdrawFunds();
}

, I can leave this code as is and see in Sentry this:

==========================================================

• checkout span [took X ms]:
  • paymentServiceCall span [took X ms]:
    • runFraudScorer span [took X ms]
    • withdrawFunds span [took X ms]
  • anyOtherMethod span [took X ms]

==========================================================

I want see this look of Trace ^
And to don't to write a lot of times this:

public void checkout() {
    ITransaction transaction = httpServletRequest.getAttribute("sentryTransactionStoredInRequestAttributesToRetrieveItFromDoFilterMethod");

    ISpan paymentServiceCall_Span = transaction.startChild("paymentServiceCall()");
    paymentServiceCall(paymentServiceCall_Span);
    paymentServiceCall_Span.finish();

    ISpan anyOtherMethod_Span = transaction.startChild("anyOtherMethod()");
    anyOtherMethod(anyOtherMethod_Span);
    anyOtherMethod_Span.finish();
}

public void paymentServiceCall(ISpan parentSpan) {
    ISpan runFraudScorer_Span = parentSpan.startChild("runFraudScorer()");
    runFraudScorer(runFraudScorer_Span);
    runFraudScorer_Span.finish();

    ISpan withdrawFunds_Span = parentSpan.startChild("withdrawFunds()");
    withdrawFunds(withdrawFunds_Span);
    withdrawFunds_Span.finish();
}

Expected Result

Described above.

Also JDBC tracing is not working, I don't see anything in Sentry, but configured that by instruction. My application.properties:

pebble.suffix = .peb
pebble.cache=false
spring.application.name=Application
management.metrics.web.server.auto-time-requests=true
spring.jpa.properties.hibernate.enable_lazy_load_no_trans=true
spring.jpa.hibernate.ddl-auto=create

spring.datasource.url=jdbc:p6spy:h2:mem:testdb
spring.datasource.username=********
spring.datasource.password=********
spring.datasource.driver-class-name=com.p6spy.engine.spy.P6SpyDriver

endpoints.enabled=true
endpoints.actuator.enabled=true
management.endpoints.enabled-by-default=false
management.endpoint.metrics.enabled=true
management.endpoints.metrics.enabled=true
management.endpoints.web.exposure.include=*

Maven:

<dependency>
    <groupId>io.sentry</groupId>
    <artifactId>sentry-jdbc</artifactId>
    <version>6.11.0</version>
</dependency>

Actual Result

No any transaction for any controller request was created. Only with instrumentation coded on my own... As the latest way and the only possible (and single working) way

[NDruce]

For sending JDBC metrics also found and tried this AutoConfiguring packages, but nothing became worked:

	<dependency>
		<groupId>com.github.gavlyukovskiy</groupId>
		<artifactId>p6spy-spring-boot-starter</artifactId>
		<version>1.8.1</version>
	</dependency>

	<dependency>
		<groupId>com.github.gavlyukovskiy</groupId>
		<artifactId>datasource-proxy-spring-boot-starter</artifactId>
		<version>1.8.1</version>
	</dependency>

Tried separately and together.

[adinauer]

Hello @NDruce I presume you're using Spring Boot 3 in combination with sentry-spring-boot-starter. Can you please give this another try with sentry-spring-boot-starter-jakarta? Sorry for the inconvenience, we're working on improving the docs on the matter. Docs have now been updated https://docs.sentry.io/platforms/java/guides/spring-boot/

[NDruce]

Thank you for help and updating documentation. Tried -jakarta dependency, temporarily commented creation of my custom transactions, runned application,
but nothing was traced to Sentry (no debug JSON-report in console and no data in Sentry). In Sentry debug I found only this:

INFO: Initializing SDK with DSN: 'https://xxx@xxx.ingest.sentry.io/xxx'
INFO: No outbox dir path is defined in options.
INFO: GlobalHubMode: 'false'
DEBUG: UncaughtExceptionHandlerIntegration enabled: true
DEBUG: UncaughtExceptionHandlerIntegration installed.
DEBUG: ShutdownHookIntegration installed.
INFO: Initializing SDK with DSN: 'https://xxx@xxx.ingest.sentry.io/xxx'
INFO: No outbox dir path is defined in options.
INFO: GlobalHubMode: 'false'
DEBUG: UncaughtExceptionHandlerIntegration removed.
INFO: Closing SentryClient.
DEBUG: Shutting down
DEBUG: UncaughtExceptionHandlerIntegration enabled: true
DEBUG: UncaughtExceptionHandlerIntegration installed.
DEBUG: ShutdownHookIntegration installed.

Possibly reason is those lines:

INFO: Closing SentryClient.
DEBUG: Shutting down

But have no idea what is cause of it

[NDruce]

Help with it please

[adinauer]

@NDruce can you please share a reproducible sample. I'm unable to reproduce your issue so far. Putting your properties in application.properties (and prefixing them with sentry., e.g. sentry.dsn=...) works for me.

[NDruce]

With settings inside application.properties doesn't starting:

---

---

pom.xml: hastebin

[adinauer]

Can you try updating your pom.xml:

<dependency>
	<groupId>io.sentry</groupId>
	<artifactId>sentry-bom</artifactId>
	<version>6.0.0-beta.2</version>
	<type>pom</type>
	<scope>import</scope>
</dependency>

Having an old version here might be causing issues.

Do other settings, that are not Sentry specific but spring specific in your applicaton.properties take effect?

[NDruce]

After updating pom.xml sentry-bom to latest 6.12.0 still
IllegalArgumentException: DSN is required. Use empty string to disable SDK.

My application.properties:

pebble.suffix = .peb
pebble.cache=false
spring.application.name=App
spring.jpa.properties.hibernate.enable_lazy_load_no_trans=true

spring.datasource.url=jdbc:p6spy:h2:mem:testdb
spring.datasource.username=user
spring.datasource.password=password
spring.datasource.driver-class-name=com.p6spy.engine.spy.P6SpyDriver
p6spy.config.modulelist=com.p6spy.engine.spy.P6SpyFactory
p6spy.enable-logging=true
p6spy.logging=slf4j

spring.jpa.hibernate.ddl-auto=create
#spring.jpa.show-sql = true
#spring.jpa.properties.hibernate.format_sql = true
#spring.jpa.properties.hibernate.use_sql_comments = true

#logging.level.org.springframework.security=DEBUG
spring.devtools.livereload.enabled=true

management.metrics.web.server.auto-time-requests=true




# TODO:

#endpoints.enabled=false
#endpoints.actuator.enabled=false
#management.endpoints.enabled-by-default=false
#management.endpoint.metrics.enabled=false
#management.endpoints.metrics.enabled=false
#management.endpoints.web.exposure.include=

# TEMP!!!: #
endpoints.enabled=true
endpoints.actuator.enabled=true
management.endpoints.enabled-by-default=false
management.endpoint.metrics.enabled=true
management.endpoints.metrics.enabled=true
management.endpoints.web.exposure.include=* 
##############

sentry.dsn=https://xxx@xxx.ingest.sentry.io/xxx
sentry.traces-sample-rate=1.0
sentry.sample-rate=1.0
sentry.debug=true
sentry.enable-tracing=true
sentry.enable-user-interaction-tracing=true
sentry.exception-resolver-order=-2147483647
sentry.send-default-pii=true
sentry.max-request-body-size=medium
sentry.logging.minimum-event-level=info
sentry.logging.minimum-breadcrumb-level=debug
sentry.max-breadcrumbs=150
#sentry.in-app-includes="com.company.app"
sentry.modulelist=com.p6spy.engine.spy.P6SpyFactory

[adinauer]

Things you can try:

• provide a reproducible sample so I can test things and help you
• check (e.g. using debugger) what's calling Sentry.init; I assume it's not our Spring Boot integration performing the init because it checks for dsn to be present.
• check Spring DEBUG log. It should show, amongst others, these lines:

Creating shared instance of singleton bean 'sentry-io.sentry.spring.boot.jakarta.SentryProperties'
SentryAutoConfiguration matched:
      - @ConditionalOnProperty (sentry.dsn) matched (OnPropertyCondition)
SentryLogbackAppenderAutoConfiguration matched:
      - @ConditionalOnClass found required classes 'ch.qos.logback.classic.LoggerContext', 'io.sentry.logback.SentryAppender' (OnClassCondition)
      - @ConditionalOnProperty (sentry.logging.enabled=true) matched (OnPropertyCondition)
      - @ConditionalOnBean (types: io.sentry.spring.boot.jakarta.SentryProperties; SearchStrategy: all) found bean 'sentry-io.sentry.spring.boot.jakarta.SentryProperties' (OnBeanCondition)

[NDruce]

Wow. I was removed Sentry.init() and now it work. But log contain only this:

[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.tracing.SentryAdviceConfiguration' of type [io.sentry.spring.jakarta.tracing.SentryAdviceConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] ocalVariableTableParameterNameDiscoverer : Using deprecated '-debug' fallback for parameter name resolution. Compile the affected code with '-parameters' instead or avoid its introspection: io.sentry.spring.jakarta.tracing.SentryAdviceConfiguration
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.tracing.SentrySpanPointcutConfiguration' of type [io.sentry.spring.jakarta.tracing.SentrySpanPointcutConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'sentrySpanPointcut' of type [org.springframework.aop.support.ComposablePointcut] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration' of type [io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] ocalVariableTableParameterNameDiscoverer : Using deprecated '-debug' fallback for parameter name resolution. Compile the affected code with '-parameters' instead or avoid its introspection: io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration$ContextTagsEventProcessorConfiguration' of type [io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration$ContextTagsEventProcessorConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] ocalVariableTableParameterNameDiscoverer : Using deprecated '-debug' fallback for parameter name resolution. Compile the affected code with '-parameters' instead or avoid its introspection: io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration$ContextTagsEventProcessorConfiguration
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'sentry-io.sentry.spring.boot.jakarta.SentryProperties' of type [io.sentry.spring.boot.jakarta.SentryProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'contextTagsEventProcessor' of type [io.sentry.spring.jakarta.ContextTagsEventProcessor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'inAppPackagesResolver' of type [io.sentry.spring.boot.jakarta.InAppIncludesResolver] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'sentryOptionsConfiguration' of type [io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration$$Lambda$653/0x000000080103f3a8] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'devAppApplication' of type [com.company.app.AppApplication$$SpringCGLIB$$0] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
INFO: Initializing SDK with DSN: 'https://xxx@xxx.ingest.sentry.io/xxx'
INFO: No outbox dir path is defined in options.
INFO: GlobalHubMode: 'false'
DEBUG: UncaughtExceptionHandlerIntegration enabled: true
DEBUG: UncaughtExceptionHandlerIntegration installed.
DEBUG: ShutdownHookIntegration installed.
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'sentryHub' of type [io.sentry.HubAdapter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'sentrySpanAdvice' of type [io.sentry.spring.jakarta.tracing.SentrySpanAdvice] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'sentrySpanAdvisor' of type [org.springframework.aop.support.DefaultPointcutAdvisor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.tracing.SentryTransactionPointcutConfiguration' of type [io.sentry.spring.jakarta.tracing.SentryTransactionPointcutConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'sentryTransactionPointcut' of type [org.springframework.aop.support.ComposablePointcut] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'sentryTransactionAdvice' of type [io.sentry.spring.jakarta.tracing.SentryTransactionAdvice] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
[  restartedMain] trationDelegate$BeanPostProcessorChecker : Bean 'sentryTransactionAdvisor' of type [org.springframework.aop.support.DefaultPointcutAdvisor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)

[  restartedMain] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat initialized with port(s): 8080 (http)

(What does all this ^ means?)

---

And contain debug about which data sent in envelops to Sentry:

DEBUG: Serializing object: {
    ...
}
DEBUG: Envelope sent successfully.
DEBUG: Envelope flushed

[NDruce]

And how to take current transaction inside controller? To create spans inside controller method

[adinauer]

Have you looked at https://docs.sentry.io/platforms/java/guides/spring-boot/performance/instrumentation/custom-instrumentation/ . It explains how you can do it. Please let me know if you have any more questions.