Call setSustainedPerformanceMode for better benchmarks#2329
Merged
stefanosiano merged 1 commit intomainfrom Nov 4, 2022
Merged
Call setSustainedPerformanceMode for better benchmarks#2329stefanosiano merged 1 commit intomainfrom
stefanosiano merged 1 commit intomainfrom
Conversation
… to get better results reduced espresso default timeout to 10 seconds updated list of devices for benchmarks
Contributor
Performance metrics 🚀
|
romtsn
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added window.setSustainedPerformanceMode(true) on benchmark activity, to get better results.
Reduced espresso default timeout to 10 seconds
Updated list of devices for benchmarks
#skip-changelog
💡 Motivation and Context
setSustainedPerformanceModeis one of the things the android benchmark runner (which we cannot use due to problems on Saucelabs) does. It tries to limit the thermal throttling by reducing the overall performance. https://developer.android.com/reference/kotlin/androidx/benchmark/junit4/AndroidBenchmarkRunner#clock-stabilityThis will result in more predictable benchmarks, as currently there are few runs failing.
Saucelabs devices for benchmarks were updated: the Google Pixel 3 was replaced because consistently timing out
💚 How did you test it?
📝 Checklist
🔮 Next steps