Skip to content

POTEL 4 - Deduplicate SpanInfo extraction#3423

Merged
adinauer merged 57 commits into
8.x.xfrom
feat/potel-4-deduplicate-span-info-extraction
Jun 18, 2024
Merged

POTEL 4 - Deduplicate SpanInfo extraction#3423
adinauer merged 57 commits into
8.x.xfrom
feat/potel-4-deduplicate-span-info-extraction

Conversation

@adinauer

Copy link
Copy Markdown
Member

📜 Description

Since we can call toSpanData on ReadableSpan we can deduplicate the code in SpanDescriptionExtractor.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 30 commits March 27, 2024 16:30
@github-actions

github-actions Bot commented May 15, 2024

Copy link
Copy Markdown
Contributor
Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 4 - Deduplicate `SpanInfo` extraction ([#3423](https://github.com/getsentry/sentry-java/pull/3423))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against c70c0a9

@github-actions

github-actions Bot commented May 15, 2024

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 359.00 ms 456.74 ms 97.74 ms
Size 1.70 MiB 2.29 MiB 598.31 KiB

Baseline results on branch: 8.x.x

Startup times

Revision Plain With Sentry Diff
a373f02 372.81 ms 432.96 ms 60.15 ms
dcad3c9 400.04 ms 479.67 ms 79.62 ms
3e1e45b 373.72 ms 439.33 ms 65.60 ms
9428efa 389.31 ms 481.67 ms 92.37 ms
34db09f 362.68 ms 443.02 ms 80.34 ms
6f16882 426.16 ms 494.15 ms 67.99 ms
9f2c855 424.20 ms 506.34 ms 82.14 ms

App size

Revision Plain With Sentry Diff
a373f02 1.70 MiB 2.28 MiB 596.35 KiB
dcad3c9 1.70 MiB 2.28 MiB 596.35 KiB
3e1e45b 1.70 MiB 2.28 MiB 596.32 KiB
9428efa 1.70 MiB 2.28 MiB 597.68 KiB
34db09f 1.70 MiB 2.28 MiB 596.37 KiB
6f16882 1.70 MiB 2.28 MiB 596.37 KiB
9f2c855 1.70 MiB 2.28 MiB 596.32 KiB

@lbloder lbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Base automatically changed from feat/potel-3-use-otel-in-sentry-api to 8.x.x June 18, 2024 05:23
@adinauer adinauer merged commit f6bd820 into 8.x.x Jun 18, 2024
@adinauer adinauer deleted the feat/potel-4-deduplicate-span-info-extraction branch June 18, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants