Report OpenTelemetry Agentless SDK and integration #4570
Conversation
…e2e / system tests
…c/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt
|
Performance metrics 🚀
|
adinauer
requested review from
lcian,
markushi,
romtsn and
stefanosiano
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| if (name.equals("sentry.java.opentelemetry.agentless-spring")) { | ||
| SentryIntegrationPackageStorage.getInstance() | ||
| .addIntegration("OpenTelemetry-Agentless-Spring"); |
There was a problem hiding this comment.
Bug: Manifest Loop Issue Causes SDK Version Overwrite
The removal of the break statement from the manifest processing loop causes versionInfo.sdkName and versionInfo.sdkVersion to be overwritten by each subsequent OpenTelemetry manifest found. This leads to non-deterministic and potentially incorrect SDK version reporting, as only the last processed manifest's details are retained. Furthermore, the maven:io.sentry:sentry-opentelemetry-agent package is no longer added, resulting in incomplete package information.
| SentryIntegrationPackageStorage.getInstance() | ||
| .addIntegration("OpenTelemetry-Agentless"); | ||
| } | ||
| if (name.equals("sentry.java.opentelemetry.agentless-spring")) { | ||
| SentryIntegrationPackageStorage.getInstance() | ||
| .addIntegration("OpenTelemetry-Agentless-Spring"); |
There was a problem hiding this comment.
I think we should add to versionInfo here, not to SentryIntegrationPackageStorage directly.
There was a problem hiding this comment.
It feels much cleaner to just remove integrations and packages from VersionInfoHolder and add them directly.
That's also what ManifestVersionDetector expects.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
#skip-changelog
📜 Description
Report OpenTelemetry Agentless SDK and integration
💡 Motivation and Context
To have better stats on which ways of combining Sentry and OpenTelemetry are most used and make most sense to invest in.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps