Skip to content

Remove indirection for integrations and packages via VersionInfoHolder #4578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

Remove indirection for integrations and packages via VersionInfoHolder #4578

merged 1 commit into from
Jul 30, 2025

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Jul 30, 2025 •
edited
Loading

#skip-changelog

📜 Description

Remove indirection for integrations and packages via VersionInfoHolder

💡 Motivation and Context

ManifestVersionDetector expects ManifestVersionReader to write to SentryIntegrationPackageStorage directly.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer Graphite App
Copy link
Member Author

adinauer commented Jul 30, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@adinauer adinauer mentioned this pull request Jul 30, 2025
Merged
7 tasks
@adinauer adinauer marked this pull request as ready for review July 30, 2025 12:57
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 374.87 ms 423.98 ms 49.11 ms
Size 1.58 MiB 2.09 MiB 519.45 KiB

Previous results on branch: 07-30-remove_indirection_for_integrations_and_packages_via_versioninfoholder

Startup times

Revision Plain With Sentry Diff
6d82b2f 437.00 ms 475.16 ms 38.16 ms

App size

Revision Plain With Sentry Diff
6d82b2f 1.58 MiB 2.09 MiB 519.44 KiB

@adinauer adinauer force-pushed the 07-30-remove_indirection_for_integrations_and_packages_via_versioninfoholder branch from d6883d6 to 12be1a9 Compare July 30, 2025 13:07
@adinauer adinauer changed the base branch from feat/report-agentless-sdk to graphite-base/4578 July 30, 2025 14:06
@adinauer adinauer force-pushed the graphite-base/4578 branch from 75436ce to 5b05195 Compare July 30, 2025 14:06
@adinauer adinauer force-pushed the 07-30-remove_indirection_for_integrations_and_packages_via_versioninfoholder branch from 12be1a9 to c2664e6 Compare July 30, 2025 14:06
@graphite-app graphite-app bot changed the base branch from graphite-base/4578 to main July 30, 2025 14:07
@adinauer adinauer force-pushed the 07-30-remove_indirection_for_integrations_and_packages_via_versioninfoholder branch from c2664e6 to 9dd706f Compare July 30, 2025 14:07
@adinauer adinauer merged commit eac12f4 into main Jul 30, 2025
41 of 43 checks passed
@adinauer Graphite App
Copy link
Member Author

adinauer commented Jul 30, 2025

Merge activity

@adinauer adinauer deleted the 07-30-remove_indirection_for_integrations_and_packages_via_versioninfoholder branch July 30, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcian lcian lcian approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adinauer @lcian