Skip to content

Conversation

@runningcode
Copy link
Contributor

📜 Description

This is the first step towards the build distribution library.

I named it sentry-build-distribution not
sentry-android-build-distribution because i thought the name was too
long. This will only ever be an android based sdk so feel free to push
back on the naming.

#skip-changelog We're not releasing anything yet

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.63 ms 457.49 ms 65.86 ms
Size 1.58 MiB 2.10 MiB 533.20 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ee747ae 382.73 ms 435.41 ms 52.68 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
3699cd5 423.60 ms 495.52 ms 71.92 ms
85d7417 347.21 ms 394.35 ms 47.15 ms
7314dbe 437.83 ms 505.64 ms 67.81 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms

App size

Revision Plain With Sentry Diff
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3699cd5 1.58 MiB 2.10 MiB 533.45 KiB
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
7314dbe 1.58 MiB 2.10 MiB 533.45 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: no/build-distribution-base

Startup times

Revision Plain With Sentry Diff
afb3e73 355.59 ms 409.86 ms 54.27 ms
4d24385 385.41 ms 478.09 ms 92.68 ms
ed6bbd2 390.40 ms 467.76 ms 77.36 ms
be098c2 408.80 ms 462.19 ms 53.39 ms

App size

Revision Plain With Sentry Diff
afb3e73 1.58 MiB 2.10 MiB 533.46 KiB
4d24385 1.58 MiB 2.10 MiB 533.45 KiB
ed6bbd2 1.58 MiB 2.10 MiB 533.18 KiB
be098c2 1.58 MiB 2.10 MiB 533.45 KiB

@romtsn
Copy link
Member

romtsn commented Sep 5, 2025

oh btw, we may need to exclude it from publications in the root project, wdyt?

if (!this.name.contains("sample") && !this.name.contains("integration-tests") && this.name != "sentry-system-test-support" && this.name != "sentry-test-support") {

@runningcode
Copy link
Contributor Author

We will eventually need to publish it, but do you mean that we should exclude it in case we have another version published before it is ready?

@romtsn
Copy link
Member

romtsn commented Sep 5, 2025

yes, I mainly meant to avoid publishing an empty module for now (we'll probably ship a new version next week already)

@runningcode runningcode force-pushed the no/build-distribution-base branch 2 times, most recently from ec7b1e8 to c9e63fd Compare September 5, 2025 13:26
cursor[bot]

This comment was marked as outdated.

@runningcode runningcode force-pushed the no/build-distribution-base branch 2 times, most recently from 1ee843c to 61d00de Compare September 5, 2025 14:43
@runningcode runningcode enabled auto-merge (squash) September 5, 2025 15:25
runningcode and others added 9 commits September 5, 2025 17:30
This is the first step towards the build distribution library.

I named it `sentry-build-distribution` not
`sentry-android-build-distribution` because i thought the name was too
long. This will only ever be an `android` based sdk so feel free to push
back on the naming.
- Renamed module directory from sentry-build-distribution to sentry-android-distribution
- Updated settings.gradle.kts to reference new module name
- Updated Android namespace from io.sentry.build.distribution to io.sentry.android.distribution
- Cleaned up build artifacts

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@runningcode runningcode force-pushed the no/build-distribution-base branch from 61d00de to 9f579b8 Compare September 5, 2025 15:30
@runningcode runningcode merged commit b750b96 into main Sep 5, 2025
44 checks passed
@runningcode runningcode deleted the no/build-distribution-base branch September 5, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants