-
-
Notifications
You must be signed in to change notification settings - Fork 461
Add build distribution module. #4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
| ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
| ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
| 85d7417 | 347.21 ms | 394.35 ms | 47.15 ms |
| 7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
| ee747ae | 357.79 ms | 421.84 ms | 64.05 ms |
| ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| 85d7417 | 1.58 MiB | 2.10 MiB | 533.44 KiB |
| 7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
Previous results on branch: no/build-distribution-base
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| afb3e73 | 355.59 ms | 409.86 ms | 54.27 ms |
| 4d24385 | 385.41 ms | 478.09 ms | 92.68 ms |
| ed6bbd2 | 390.40 ms | 467.76 ms | 77.36 ms |
| be098c2 | 408.80 ms | 462.19 ms | 53.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| afb3e73 | 1.58 MiB | 2.10 MiB | 533.46 KiB |
| 4d24385 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| ed6bbd2 | 1.58 MiB | 2.10 MiB | 533.18 KiB |
| be098c2 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
romtsn
reviewed
Sep 5, 2025
romtsn
approved these changes
Sep 5, 2025
Member
|
oh btw, we may need to exclude it from publications in the root project, wdyt? Line 164 in 5af7d23
|
Contributor
Author
|
We will eventually need to publish it, but do you mean that we should exclude it in case we have another version published before it is ready? |
Member
|
yes, I mainly meant to avoid publishing an empty module for now (we'll probably ship a new version next week already) |
ec7b1e8 to
c9e63fd
Compare
1ee843c to
61d00de
Compare
This is the first step towards the build distribution library. I named it `sentry-build-distribution` not `sentry-android-build-distribution` because i thought the name was too long. This will only ever be an `android` based sdk so feel free to push back on the naming.
- Renamed module directory from sentry-build-distribution to sentry-android-distribution - Updated settings.gradle.kts to reference new module name - Updated Android namespace from io.sentry.build.distribution to io.sentry.android.distribution - Cleaned up build artifacts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
61d00de to
9f579b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This is the first step towards the build distribution library.
I named it
sentry-build-distributionnotsentry-android-build-distributionbecause i thought the name was toolong. This will only ever be an
androidbased sdk so feel free to pushback on the naming.
#skip-changelog We're not releasing anything yet
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps