-
-
Notifications
You must be signed in to change notification settings - Fork 461
Add build distribution module. #4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
82ac941
Add build distribution module.
runningcode 0a5044b
Format code
getsentry-bot 1710ab6
Add Distribution class
runningcode 1283668
Format code
getsentry-bot aab0c0f
Rename sentry-build-distribution module to sentry-android-distribution
runningcode 154f651
Don't publish build-distribution, align kotlin versions
runningcode 0471b9a
Specify explicity visibility
runningcode 07b541c
Use Kotlin 2_0
runningcode 9f579b8
Use Kotlin 1_9
runningcode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
sentry-android-distribution/api/sentry-android-distribution.api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| public final class io/sentry/android/distribution/Distribution { | ||
| public fun <init> ()V | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import org.jetbrains.kotlin.config.KotlinCompilerVersion | ||
| import org.jetbrains.kotlin.gradle.dsl.KotlinVersion | ||
|
|
||
| plugins { | ||
| id("com.android.library") | ||
| alias(libs.plugins.kotlin.android) | ||
| } | ||
|
|
||
| android { | ||
| compileSdk = libs.versions.compileSdk.get().toInt() | ||
| namespace = "io.sentry.android.distribution" | ||
|
|
||
| defaultConfig { minSdk = libs.versions.minSdk.get().toInt() } | ||
| buildFeatures { buildConfig = false } | ||
| } | ||
|
|
||
| kotlin { | ||
| jvmToolchain(17) | ||
| compilerOptions.languageVersion = KotlinVersion.KOTLIN_1_9 | ||
| explicitApi() | ||
| } | ||
|
|
||
| androidComponents.beforeVariants { | ||
| it.enable = !Config.Android.shouldSkipDebugVariant(it.buildType) | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation(projects.sentry) | ||
| implementation(kotlin(Config.kotlinStdLib, KotlinCompilerVersion.VERSION)) | ||
| } |
3 changes: 3 additions & 0 deletions
3
sentry-android-distribution/src/main/java/io/sentry/android/distribution/Distribution.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| package io.sentry.android.distribution | ||
|
|
||
| public class Distribution {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent BOM Exclusion Logic
The BOM's exclusion for
sentry-android-distributionuses a substring match, which is inconsistent with other exact-name exclusions. This could unintentionally prevent future modules whose names contain "sentry-android-distribution" from being included in the BOM.