Skip to content

Conversation

@lbloder
Copy link
Collaborator

@lbloder lbloder commented Nov 24, 2025

📜 Description

Check for Platform before trying to instantiate converter/profiler.

💡 Motivation and Context

Currently, when starting up a Sentry-Enabled Android app we log a warning about not being able to instantiate the profile converter, this is, however, only relevant for the JVM.

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lbloder lbloder enabled auto-merge (squash) November 24, 2025 13:25
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 332.77 ms 397.46 ms 64.69 ms
Size 1.58 MiB 2.13 MiB 557.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7314dbe 437.83 ms 505.64 ms 67.81 ms
dcc6bbf 382.58 ms 462.13 ms 79.54 ms
a5ab36f 316.83 ms 394.54 ms 77.71 ms
27d7cf8 314.17 ms 347.00 ms 32.83 ms
96449e8 361.30 ms 423.39 ms 62.09 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
d217708 409.83 ms 474.72 ms 64.89 ms
fcec2f2 311.35 ms 384.94 ms 73.59 ms
85d7417 347.21 ms 394.35 ms 47.15 ms
bdbe1f4 380.66 ms 464.44 ms 83.78 ms

App size

Revision Plain With Sentry Diff
7314dbe 1.58 MiB 2.10 MiB 533.45 KiB
dcc6bbf 1.58 MiB 2.12 MiB 553.10 KiB
a5ab36f 1.58 MiB 2.12 MiB 555.26 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
96449e8 1.58 MiB 2.11 MiB 539.35 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
fcec2f2 1.58 MiB 2.12 MiB 551.51 KiB
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
bdbe1f4 1.58 MiB 2.11 MiB 538.88 KiB

Previous results on branch: fix/warning-about-converter-on-android

Startup times

Revision Plain With Sentry Diff
4327d64 325.04 ms 397.06 ms 72.02 ms

App size

Revision Plain With Sentry Diff
4327d64 1.58 MiB 2.13 MiB 557.33 KiB

@lbloder lbloder merged commit 8285e52 into main Nov 24, 2025
60 of 61 checks passed
@lbloder lbloder deleted the fix/warning-about-converter-on-android branch November 24, 2025 15:20
43jay pushed a commit that referenced this pull request Nov 25, 2025
Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants