-
-
Notifications
You must be signed in to change notification settings - Fork 464
feat(envelope-item): Support span type #4935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
82276e8
4a59c7b
1167819
39664b5
db9a241
71a1fa0
65d8e80
855d9f8
8628ab9
f287714
7860647
7b0f12f
8d42537
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,7 @@ public enum SentryItemType implements JsonSerializable { | |
| CheckIn("check_in"), | ||
| Feedback("feedback"), | ||
| Log("log"), | ||
| Span("span"), | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Unknown("__unknown__"); // DataCategory.Unknown | ||
|
|
||
| private final String itemType; | ||
|
Comment on lines
23
to
29
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. valid concern but I am not sure if we need to handle this now since we cannot capture spans directly from the java sdk anyway
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hm, I think it's still valid even for the hybrid SDKs because client reports are counted from the unsent envelop items? But anyway, it can be done in a follow up PR later
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll double check this |
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.