-
-
Notifications
You must be signed in to change notification settings - Fork 463
Discard envelopes on 4xx and 5xx response
#4950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f634d01 | 359.58 ms | 433.88 ms | 74.30 ms |
| 9fbb112 | 401.87 ms | 515.87 ms | 114.00 ms |
| d5a29b6 | 298.62 ms | 391.78 ms | 93.16 ms |
| bbc35bb | 298.53 ms | 372.17 ms | 73.64 ms |
| b3d8889 | 420.46 ms | 453.71 ms | 33.26 ms |
| a5ab36f | 320.47 ms | 389.77 ms | 69.30 ms |
| ee747ae | 405.43 ms | 485.70 ms | 80.28 ms |
| 951caf7 | 323.66 ms | 392.82 ms | 69.16 ms |
| b6702b0 | 395.86 ms | 409.98 ms | 14.12 ms |
| 27d7cf8 | 369.82 ms | 422.62 ms | 52.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f634d01 | 1.58 MiB | 2.10 MiB | 533.40 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| d5a29b6 | 1.58 MiB | 2.12 MiB | 549.37 KiB |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
| a5ab36f | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 951caf7 | 1.58 MiB | 2.13 MiB | 558.77 KiB |
| b6702b0 | 1.58 MiB | 2.12 MiB | 551.79 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
📜 Description
Envelopes are now discarded on a
4xxor5xxresponse instead of retrying them.4xxit's most likely an SDK (e.g. incorrect serialization) or envelope problem (e.g. too large) where retry does not make sense.5xxresponse in order not to take down Sentry by accumulating lots of envelopes in case of an outage where after restoring functionality Sentry is hit by too many requests.💡 Motivation and Context
Fixes #4921
Fixes #4936
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps