Skip to content

Conversation

@lucas-zimerman
Copy link
Contributor

@lucas-zimerman lucas-zimerman commented Dec 9, 2025

📜 Description

Metric support - this PR is needed for Capacitor/Dart/Flutter/React-Native right now but will be needed in general in the future when Java also implements Metric support

💡 Motivation and Context

See metric protocol: https://develop.sentry.dev/sdk/telemetry/metrics/

Needed for processing envelope items with type trace_metric. Without this change, Hybrid SDKs will lose their metric data by replacing type trace_metric by __unknown__.

💚 How did you test it?

Unit test

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Close #4957

@lucas-zimerman
Copy link
Contributor Author

failing test is due to me not having permission on this repo.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review December 9, 2025 12:32
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Also tested locally and confirmed that metrics are displayed for Android.

Image

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman
Copy link
Contributor Author

image working as expected 🗡️

@lucas-zimerman
Copy link
Contributor Author

just adding a note that I can't merge PRs here :D

@romtsn romtsn merged commit 91bb874 into getsentry:main Dec 9, 2025
57 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hybrid SDKs: support for trace_metric envelope type.

4 participants