Skip to content

feat: Made ManifestMetaDataReader read the DIST#5107

Merged
bitsandfoxes merged 5 commits intomainfrom
feat/manifest-read-dist
Mar 3, 2026
Merged

feat: Made ManifestMetaDataReader read the DIST#5107
bitsandfoxes merged 5 commits intomainfrom
feat/manifest-read-dist

Conversation

@bitsandfoxes
Copy link
Contributor

📜 Description

The ManifestMetaDataReader reads a lot of things, but not DIST. But the DIST can be provided through the options. Now if the Sentry SDK for Unity would want to share its DIST with the Android layer, it cannot do so if it sets up auto-initialization.

💡 Motivation and Context

Why is this change required?
Because the ManifestMetaDataReader did not read DIST - until now.

What problem does it solve?
It solves the problem of the ManifestMetaDataReader not reading the DIST.

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Release!

@bitsandfoxes bitsandfoxes changed the title feat: ManifestMetaDataReader reads DIST feat: Made ManifestMetaDataReader read the DIST Feb 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (otel) Create sentry-opentelemetry-otlp module for combining OpenTelemetry SDK OTLP export with Sentry SDK by adinauer in #5100
  • (screenshot) Add screenshot masking using view hierarchy by romtsn in #5077
  • Made ManifestMetaDataReader read the DIST by bitsandfoxes in #5107

Bug Fixes 🐛

  • (android) Remove AndroidRuntimeManager to prevent ANRs during SDK init by romtsn in #5127
  • (gestures) Use peekDecorView to not force view hierarchy construction by romtsn in #5134
  • (init) Reduce allocations and bytecode instructions during Sentry.init by romtsn in #5135
  • (transport) Handle HTTP 413 with actionable log and use send_error for HTTP errors by adinauer in #5115
  • Trim DSN string before URI parsing by adinauer in #5113
  • Safe unregister SystemEventsBroadcastReceiver by kollesnica1337 in #5106

Internal Changes 🔧

Deps

  • Bump getsentry/craft from 2.21.7 to 2.23.1 by dependabot in #5129
  • Update Native SDK to v0.13.1 by github-actions in #5104
  • Bump actions/upload-artifact from 6 to 7 by dependabot in #5130
  • Bump actions/download-artifact from 7 to 8 by dependabot in #5132
  • Bump gradle/actions from 5.0.1 to 5.0.2 by dependabot in #5131
  • Bump github/codeql-action from 4.32.2 to 4.32.4 by dependabot in #5109
  • Bump getsentry/craft from 2.21.2 to 2.21.7 by dependabot in #5110

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ef75d75

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 343.04 ms 421.92 ms 78.88 ms
Size 1.58 MiB 2.29 MiB 722.92 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
91bb874 310.68 ms 359.24 ms 48.56 ms
e59e22a 368.02 ms 432.00 ms 63.98 ms
fc5ccaf 279.11 ms 353.34 ms 74.23 ms
d15471f 315.20 ms 370.22 ms 55.02 ms
d15471f 286.65 ms 314.68 ms 28.03 ms
d15471f 342.08 ms 415.44 ms 73.35 ms
ad8da22 314.38 ms 352.29 ms 37.91 ms
cf708bd 434.73 ms 502.96 ms 68.22 ms
abfcc92 309.54 ms 380.32 ms 70.78 ms
91bb874 314.47 ms 440.00 ms 125.53 ms

App size

Revision Plain With Sentry Diff
91bb874 1.58 MiB 2.13 MiB 559.07 KiB
e59e22a 1.58 MiB 2.20 MiB 635.34 KiB
fc5ccaf 1.58 MiB 2.13 MiB 557.54 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
ad8da22 1.58 MiB 2.29 MiB 719.83 KiB
cf708bd 1.58 MiB 2.11 MiB 539.71 KiB
abfcc92 1.58 MiB 2.13 MiB 557.31 KiB
91bb874 1.58 MiB 2.13 MiB 559.07 KiB

Previous results on branch: feat/manifest-read-dist

Startup times

Revision Plain With Sentry Diff
97c89a2 464.10 ms 546.84 ms 82.74 ms
f699980 323.11 ms 404.30 ms 81.19 ms
e26855b 328.09 ms 396.90 ms 68.81 ms

App size

Revision Plain With Sentry Diff
97c89a2 1.58 MiB 2.29 MiB 719.77 KiB
f699980 1.58 MiB 2.29 MiB 719.77 KiB
e26855b 1.58 MiB 2.29 MiB 722.91 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please don't reformat the whole CHANGELOG.md 🥲

@bitsandfoxes bitsandfoxes requested a review from markushi March 3, 2026 13:34
@dingsdax dingsdax self-requested a review March 3, 2026 14:26
@romtsn romtsn dismissed markushi’s stale review March 3, 2026 14:34

addressed the feedback :)

@bitsandfoxes bitsandfoxes merged commit b8bd880 into main Mar 3, 2026
65 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/manifest-read-dist branch March 3, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants