fix(spring): [Cache Tracing 21] Fix get(key, type) double-call in SentryCacheWrapper#5210
Draft
adinauer wants to merge 1 commit intoref/cache-tracing-rename-constantsfrom
Draft
Conversation
Use a single delegate.get(key, type) call instead of calling delegate.get(key) for hit detection and delegate.get(key, type) for the actual value. This eliminates doubled cache round trips (e.g. Redis network calls) and a TOCTOU race where the entry could expire between the two calls. The trade-off is that cached null values are now indistinguishable from cache misses, which is acceptable for observability purposes.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Spring
Other
Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
Sentry Build Distribution
|
This was referenced Mar 18, 2026
Draft
fix(spring): [Cache Tracing 14] Fix cache hit detection for typed get and fix jcache docs link
#5203
Draft
Draft
Draft
Member
Author
|
@sentry review |
Member
Author
|
cursor review |
8 tasks
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- [Cache Tracing 21] Fix get(key, type) double-call in SentryCacheWrapper ([#5210](https://github.com/getsentry/sentry-java/pull/5210))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Cache Tracing)