ref(feedback): Rename Dialog to Form across feedback APIs#5349
Open
ref(feedback): Rename Dialog to Form across feedback APIs#5349
Conversation
Rename SentryUserFeedbackDialog to SentryUserFeedbackForm as the primary class. Keep SentryUserFeedbackDialog as a deprecated subclass for backward compatibility. Also rename internal APIs to use Form naming consistently: - IDialogHandler -> IFormHandler - showDialog -> showForm - setDialogHandler/getDialogHandler -> setFormHandler/getFormHandler - AndroidUserFeedbackIDialogHandler -> AndroidUserFeedbackFormHandler Add deprecated Sentry.showUserFeedbackDialog() overloads that delegate to the new Sentry.showUserFeedbackForm() methods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5865051 | 319.74 ms | 365.60 ms | 45.86 ms |
| cf708bd | 408.35 ms | 458.98 ms | 50.63 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
| 1df7eb6 | 397.04 ms | 429.64 ms | 32.60 ms |
| 9ea89e8 | 308.06 ms | 358.16 ms | 50.10 ms |
| 319f256 | 315.96 ms | 372.96 ms | 57.00 ms |
| c8125f3 | 383.82 ms | 441.66 ms | 57.84 ms |
| f064536 | 327.04 ms | 405.35 ms | 78.31 ms |
| b3d8889 | 420.46 ms | 453.71 ms | 33.26 ms |
| f064536 | 335.52 ms | 408.79 ms | 73.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5865051 | 0 B | 0 B | 0 B |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
| 1df7eb6 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 9ea89e8 | 1.58 MiB | 2.28 MiB | 716.23 KiB |
| 319f256 | 1.58 MiB | 2.19 MiB | 619.79 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| f064536 | 1.58 MiB | 2.20 MiB | 633.90 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
| f064536 | 1.58 MiB | 2.20 MiB | 633.90 KiB |
…onstructors Use SentryUserFeedbackDialog.OptionsConfiguration as the parameter type in the deprecated Builder constructors so old compiled code looking for the original descriptor still resolves correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…name Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
SentryUserFeedbackDialogtoSentryUserFeedbackFormas the primary feedback UI class. The oldSentryUserFeedbackDialogis kept as a deprecated subclass for backward compatibility — existing user code continues to compile and work unchanged.Public API:
Sentry.showUserFeedbackForm()New
Sentry.showUserFeedbackForm()methods replace the deprecatedSentry.showUserFeedbackDialog()overloads, which now delegate to the new ones.Internal API renames
Internal-only types and methods are renamed directly (no deprecation shim needed):
IDialogHandler→IFormHandler,showDialog()→showForm(),setDialogHandler()/getDialogHandler()→setFormHandler()/getFormHandler(),AndroidUserFeedbackIDialogHandler→AndroidUserFeedbackFormHandler.Closes #5304