feat(tombstones): Add option to attach raw tombstone as protobuf#5446
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| 27d7cf8 | 369.82 ms | 422.62 ms | 52.80 ms |
| 33a08cc | 267.08 ms | 340.45 ms | 73.37 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
| 96eeafa | 361.43 ms | 455.07 ms | 93.63 ms |
| 22f4345 | 314.79 ms | 375.02 ms | 60.23 ms |
| 8c1fb22 | 316.62 ms | 352.78 ms | 36.16 ms |
| cf708bd | 434.73 ms | 502.96 ms | 68.22 ms |
| 48277cd | 320.38 ms | 379.90 ms | 59.52 ms |
| 22f4345 | 307.87 ms | 354.51 ms | 46.64 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| 33a08cc | 1.58 MiB | 2.12 MiB | 555.28 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
| 96eeafa | 1.58 MiB | 2.19 MiB | 620.21 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| 8c1fb22 | 0 B | 0 B | 0 B |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| 48277cd | 0 B | 0 B | 0 B |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9a4963e. Configure here.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
supervacuus
approved these changes
May 19, 2026
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
This looks good, only minor comments.
Just one general assessment: the tombstone also includes raw memory views into regions pointed to by register contents. These are potentially PII-relevant and should move the tombstone attachment into a PII category similar to minidumps. This might also raise storage retention as a follow-up.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
@supervacuus thanks for the review 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📜 Description
Adds a new
attachRawTombstoneoption (defaultfalse) that attaches the raw tombstone protobuf fromApplicationExitInfo.getTraceInputStream()as an attachment on native crash events.Changes:
Hint.java: Addedtombstonefield with getter/setterAttachment.java: AddedfromTombstone(byte[])factory method (tombstone.pb,application/x-protobuf)SentryClient.java: Retrieves tombstone from hint and adds to envelope attachmentsSentryAndroidOptions.java: AddedattachRawTombstoneboolean option with getter/setterTombstoneIntegration.java: Buffers raw bytes from the trace InputStream before parsing, attaches when option is enabledManifestMetadataReader.java: Addedio.sentry.tombstone.attach-rawmanifest meta-data optionUsage
Kotlin (programmatic):
AndroidManifest.xml:
💡 Motivation and Context
Allows users to get the raw tombstone protobuf alongside the parsed native crash event, useful for deeper post-mortem analysis.
💚 How did you test it?
Manually tested on a physical device (HMD Pulse, Android 15) by triggering a native crash in the sample app and verifying the tombstone attachment is present.
https://sentry-sdks.sentry.io/issues/7229399848/events/1e81d1e1ed9a400b78e1be7811776a18/
Downloaded the raw tombstone file and verified it can be correctly parsed and viewed via
protoc:tombstone.txt
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps