chore(ci): Skip Spring Boot tests when updating Android modules#5453
Open
0xadam-brown wants to merge 1 commit into
Open
chore(ci): Skip Spring Boot tests when updating Android modules#54530xadam-brown wants to merge 1 commit into
0xadam-brown wants to merge 1 commit into
Conversation
📲 Install BuildsAndroid
|
0xadam-brown
changed the title
0xadam-brown
force-pushed
the
chore/ci-spring-boot-matrix-path-filter
branch
2 times, most recently
from
c0ee1c1 to
1127834
Compare
… (JAVA-510) Prior to this commit, Android-only PRs were silently triggering 14 unrelated Spring Boot matrix jobs (up to 45 min each). The pull_request trigger had no path filter at all, and the push filter only matched one of the ~10 Android modules. This commit fixes both issues by adding the missing PR filter and broadening the pattern to cover all Android directories, so Spring Boot CI skips entirely when nothing Spring-related changed.
0xadam-brown
force-pushed
the
chore/ci-spring-boot-matrix-path-filter
branch
from
1127834 to
1ccfc5c
Compare
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| 27d7cf8 | 369.82 ms | 422.62 ms | 52.80 ms |
| 33a08cc | 267.08 ms | 340.45 ms | 73.37 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
| 96eeafa | 361.43 ms | 455.07 ms | 93.63 ms |
| 22f4345 | 314.79 ms | 375.02 ms | 60.23 ms |
| 8c1fb22 | 316.62 ms | 352.78 ms | 36.16 ms |
| cf708bd | 434.73 ms | 502.96 ms | 68.22 ms |
| 48277cd | 320.38 ms | 379.90 ms | 59.52 ms |
| 22f4345 | 307.87 ms | 354.51 ms | 46.64 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| 33a08cc | 1.58 MiB | 2.12 MiB | 555.28 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
| 96eeafa | 1.58 MiB | 2.19 MiB | 620.21 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| 8c1fb22 | 0 B | 0 B | 0 B |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| 48277cd | 0 B | 0 B | 0 B |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
8 tasks
0xadam-brown
changed the title
runningcode
approved these changes
May 21, 2026
Contributor
runningcode
left a comment
runningcode
left a comment
There was a problem hiding this comment.
Maybe we should always run everything on the main branch but just ignore it for PR builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Android-only PRs were silently triggering 14 unrelated Spring Boot matrix jobs (up to 45 min each) on every push and PR. The
pull_requesttrigger had no path filter at all, and thepushfilter only matched one of the ~10 Android modules.This PR fixes both issues by adding the missing
pull_requestfilter and broadening thepushpattern to cover all Android directories. Now Spring Boot CI will be skipped when nothing Spring-related changed.Quantifying the win
💡 Motivation and Context
@runningcode rightly pointed out that our CI times were obnoxiously long and got us to look for easy wins to shorten them. This is one. (Thanks @runningcode 💯)
addresses: JAVA-510
💚 How did you test it?
CI configuration only — no code behaviour changed. Verified glob semantics:
sentry-android*/**is anchored to the repo root and correctly covers allsentry-android-*top-level directories.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog