Default dsn when set to an empty string#546
Merged
bretthoerner merged 1 commit intogetsentry:masterfrom Jan 15, 2018
Merged
Conversation
emcfarlane
force-pushed
the
dsn-empty-string
branch
from
3c8f377 to
e89f5c7
Compare
|
Thanks, looks good. Do you mind making a quick change to use our utility function? https://github.com/getsentry/sentry-java/blob/master/sentry/src/main/java/io/sentry/util/Util.java#L25 |
emcfarlane
force-pushed
the
dsn-empty-string
branch
from
e89f5c7 to
de544be
Compare
Author
|
@bretthoerner fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so environment variable
SENTRY_DSNcan be set to an empty string without failing.