Build distribution zip files & upload to Zeus#979
Merged
bruno-garcia merged 5 commits intomainfrom Oct 16, 2020
Merged
Conversation
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
Codecov Report
@@ Coverage Diff @@
## main #979 +/- ##
=========================================
Coverage 71.57% 71.57%
Complexity 1294 1294
=========================================
Files 134 134
Lines 4725 4725
Branches 489 489
=========================================
Hits 3382 3382
Misses 1087 1087
Partials 256 256 Continue to review full report at Codecov.
|
marandaneto
reviewed
Oct 14, 2020
Contributor
Author
|
Should I add entry in changelog or we just ignore this validation here? |
maciejwalkowiak
changed the title
bruno-garcia
approved these changes
Oct 16, 2020
Member
No need, if it's not relevant for the SDK users it's fine to ignore it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Build distribution zip files containing all files needed to be published to Maven.
Executing
./gradlew distZipcreates in each module that is meant to be published (not in samples or support modules) a filebuild/distributions/<module-name>-<version>.zip.💡 Motivation and Context
Solves #950, #951
💚 How did you test it?
📝 Checklist
🔮 Next steps
Find out how to publish files to Maven repository using either plain HTTP requests, Maven or Gradle (#952).