chore: add release discovery #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Aug 22, 2022
Comment on lines
+19
to
+24
| "SENTRY_RELEASE", | ||
| "SOURCE_VERSION", // Heroku #1 https://devcenter.heroku.com/changelog-items/630 | ||
| "HEROKU_SLUG_COMMIT", // Heroku #2: https://docs.sentry.io/product/integrations/deployment/heroku/#configure-releases | ||
| "CODEBUILD_RESOLVED_SOURCE_VERSION", // AWS CodeBuild: https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-env-vars.html | ||
| "CIRCLE_SHA1", // CircleCI: https://circleci.com/docs/2.0/env-vars/ | ||
| "VERCEL_GIT_COMMIT_SHA", // Vercel docs: https://vercel.com/docs/concepts/projects/environment-variables#system-environment-variables |
Member
There was a problem hiding this comment.
Does the order matter here? If yes, is the order correct?
(Looking at it again, I think it doesn't but I'm not sure about Heroku...)
Contributor
Author
There was a problem hiding this comment.
Great question! It does. This is why SENTRY_RELEASE is on the top of the list, everything else is carrying equal weight. I was thinking to extract SENTRY_RELEASE from the rest of the pack but found it to be overkill
Member
There was a problem hiding this comment.
Thanks for explaining. Makes sense! Then, let's make sure to add a comment that SENTRY_RELEASE should be the first item in the list.
Contributor
Author
There was a problem hiding this comment.
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: #20
This behaviour tries to replicate the behaviour of release option of sentry-webpack-plugin.
Release name can be specified via process.env.SENTRY_RELEASE. Otherwise, it will automatically detects values for Heroku, AWS CodeBuild, CircleCI and Vercel. Otherwise uses HEAD's commit SHA. (For HEAD option, requires access to git CLI and for the root directory to be a valid repository).
Logic taken from sentry-cli here