Conversation
mydea
reviewed
Apr 28, 2023
| (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && | ||
| github.actor != 'dependabot[bot]' | ||
| github.actor != 'dependabot[bot]' && | ||
| ${{ false }} # Debug ID backend changes broke the E2E tests, we need to revisit them |
Member
There was a problem hiding this comment.
not sure if this will work, nesting this inside of if here? I think the safer is 1 == 2 or something like this? Never 100% sure about this in the GHA yaml format 😅
Lms24
approved these changes
Apr 28, 2023
mydea
approved these changes
Apr 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The switch to the newer artifact bundle upload has rendered our e2e tests faulty because the endpoint we ping to check for uploaded source maps doesn't return them anymore.
For now we disable them so we can have green CI again.