- Turn off
no-base-to-string, as we rely on casting things to strings in many places after verifying that they are simple not-falsey. It could be worthwhile to impose better type safety on all these things at some point, but that is unlikely to be worth doing in the near term.
- Remove several unused variables. We could consider disabling this rule in tests specifically, since that is where it's most common to leave scaffolding and debugging values behind.
- Cast as types in a few cases to make our intention clear, where the values were actually being used safely, but not explicitly.
- Disable
require-array-sort-compare in one case where we benefit with a smaller code footprint by using the implicit numeric comparison on Array.sort().
Note
The pull request "chore(lint): resolve oxlint warnings" was created by @isaacs but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.
no-base-to-string, as we rely on casting things to strings in many places after verifying that they are simple not-falsey. It could be worthwhile to impose better type safety on all these things at some point, but that is unlikely to be worth doing in the near term.require-array-sort-comparein one case where we benefit with a smaller code footprint by using the implicit numeric comparison onArray.sort().