Vendor in @opentelemetry/instrumentation-knex into the SDK.
Follow this process:
- Vendor the instrumentation as-is, with as little changes as possible.
- Make sure each vendored file contains the licence on top.
- Generally follow this folder layout:
src/integrations/tracing/knex/index.ts for the Sentry integration
src/integrations/tracing/knex/vendored/xxx for vendored files
- Vendor in sub-dependencies of the instrumentation as much as possible, including types. Avoid adding runtime dependencies to the SDK.
- Disable eslint for the files if necessary in the initial PR, and fix those in a follow-up.
- In a follow-up PR, adapt or streamline the instrumentation to SDK needs, removing parts that are not needed.
- Finally, rewrite integrations to not depend on
@opentelemetry/instrumentation but implement an internal base.
Vendor in
@opentelemetry/instrumentation-knexinto the SDK.Follow this process:
src/integrations/tracing/knex/index.tsfor the Sentry integrationsrc/integrations/tracing/knex/vendored/xxxfor vendored files@opentelemetry/instrumentationbut implement an internal base.