fix(react-router): prevent unstable_sentryVitePluginOptions spread from overwriting sourcemaps - #22930
Closed
okxint wants to merge 1 commit into
Closed
Conversation
…om overwriting sourcemaps
Member
chargome
added a commit
that referenced
this pull request
Aug 3, 2026
…yVitePluginOptions` is set (#22945) A trailing `...unstable_sentryVitePluginOptions` spread sat after `sourcemaps: { disable: true }`, and object spread replaces whole keys rather than deep-merging — so any user-supplied `sourcemaps` object dropped `disable`. The Vite plugin then injected a second debug ID on top of the one from `sentryOnBuildEnd`. The spread now sits between the plain options and the field-wise merged objects: it can still<br>override flat keys (its documented contract) but can't replace `sourcemaps`, `release`, `_metaOptions` or `reactComponentAnnotation`. supersedes [#22930](<#22930>) — credit to @okxint for the same diagnosis. closes #22929 --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeCustomSentryVitePluginsbuilds asourcemaps: { disable: true, ...user }object to prevent double debug-ID injection during the React Router build. However, the trailing...unstable_sentryVitePluginOptionsspread on the next line overwrites the entiresourcemapskey with the user's raw value, droppingdisable: true.JavaScript's object spread is shallow — when both
sourcemaps: { disable: true, ...userSourcemaps }and...unstable_sentryVitePluginOptionsare present on the same level, the secondsourcemapskey wins unconditionally.Fix: destructure
sourcemapsout ofunstable_sentryVitePluginOptionsbefore the call, then useuserSourcemapsinside the already-merged object and spread the remainder separately. This keeps user customizations on all other keys while preservingdisable: true.Fixes #22929