Fix _processing flag in BaseClient.#2983
Merged
kamilogorek merged 2 commits intogetsentry:masterfrom Oct 20, 2020
Merged
Conversation
0e04728 to
a549a70
Compare
Client processes events concurrently so it should be a counter, not a boolean.
a549a70 to
a65799e
Compare
Contributor
|
I'm totally fine with a solution like that. And thankfully it works out of the box with my todays changes to processEvent 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had experienced some problems with
flush()in a following scenario:I tried to change
fs.readFiletofs.readFileSyncinpackages/node/src/parsers.tsbut file I/O is not the only issue.beforeSendcallback could result in asynchronous execution too.So my proposal is to change
_processingfrombooleantonumbercounter. Another option would be to introduce anotherPromiseBufferand justdrainit. What do you think?