Typescript - BaseNodeOptions does not have dsn property

[dmusev]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/node

SDK Version

7.5.1

Framework Version

No response

Link to Sentry event

No response

Steps to Reproduce

Using node application with latest @sentry/node fails to compile TypeScript due to missing types in BaseNodeOptions.

I saw similar issue being fixed for @sentry/browser here: #4746

Maybe such a fix is needed for the @sentry/node package as well. @lforst can you confirm ?

Expected Result

TS should compile without warnings.

Actual Result

[AbhiPrasad]

Hey, thanks for writing in! Are you importing in BaseNodeOptions yourself? Or is this error happening when you call Sentry.init()?

You shouldn't need to use BaseNodeOptions here. You'll need to use NodeOptions for Sentry.init or NodeClientOptions for the NodeClient class constructor.

[dmusev]

@AbhiPrasad Thanks for you quick response, the point is that we are not using any options as constructor or whatsoever, we are just calling the init function and passing the said configuration as object, like:

[lforst]

@dmusev How are you importing init?

[dmusev]

@lforst Sorry, forgot to mention that as well, we are exporting it with destruction directly from @sentry/node, like:

[lforst]

@dmusev Thanks! Can you share the TypeScript version you're on? You can check this in VS Code by clicking on the curly braces in the bottom right corner:

Also can you check your lockfile if all Sentry dependencies are on 7.5.1? Thanks!

[dmusev]

@lforst I am using typescript ver. 4.7.4, I also checked lock file and all seems updated. Need to note that we are using pnpm for package management, might it be messing up somehow node modules? I am also running into this error while building inside docker container with node 16.15.1

[lforst]

@dmusev This error seems very weird to me. I wouldn't even know how we could mess up anything so that it would be an issue like this...

Just for the sake of it, can you try installing your packages with npm/yarn. I think pnpm installs your packages globally or something and I wanna rule out that this causes some issues.

Also can you open the file node_modules/@sentry/node/types/types.d.ts and hover over the Options type in that file and share a screenshot. We'd like to see if TS can resolve that type.

[dmusev]

@lforst Thanks so much, it seems that @sentry/types package was missing, and needed to add it manually...

Simply installing @sentry/types fixed the issue, weird it did not install it as it seems to be a dependency. 🎉 👍