With Sphinx, the title underlines need to be at least as long as the … #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not to be nitpicky, but I think most other places we just keep the length of the underline the same as the length of the title. |
docs/integrations/react.rst
Outdated
|
|
||
| Expanded Usage | ||
| -------------- | ||
| ---------------- |
Contributor
There was a problem hiding this comment.
They need to match exactly, it can't be longer either.
Contributor
Author
There was a problem hiding this comment.
i don't like rst
Contributor
Author
There was a problem hiding this comment.
are you sure though? the other ones were working before
Contributor
Author
There was a problem hiding this comment.
i fixed it. bleh
evanpurkhiser
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…title
😭