Skip to content

fix(tracemetrics): Bump metric buffer to 1k #18039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2025
Merged

fix(tracemetrics): Bump metric buffer to 1k #18039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c455ac2
fix(tracemetrics): Bump metric buffer to 1k
k-fish Oct 26, 2025
69c45a4
Merge branch 'develop' into fix/tracemetrics/buffer-1000
k-fish Oct 27, 2025
7848a3b
update test
chargome Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/metrics/internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { timestampInSeconds } from '../utils/time';
import { _getTraceInfoFromScope } from '../utils/trace-info';
import { createMetricEnvelope } from './envelope';

const MAX_METRIC_BUFFER_SIZE = 100;
const MAX_METRIC_BUFFER_SIZE = 1000;

/**
* Converts a metric attribute to a serialized metric attribute.
Expand Down
6 changes: 3 additions & 3 deletions packages/core/test/lib/metrics/internal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,12 +249,12 @@ describe('_INTERNAL_captureMetric', () => {
const scope = new Scope();
scope.setClient(client);

// Fill the buffer to max size (100 is the MAX_METRIC_BUFFER_SIZE constant)
for (let i = 0; i < 100; i++) {
// Fill the buffer to max size (1000 is the MAX_METRIC_BUFFER_SIZE constant)
for (let i = 0; i < 1000; i++) {
_INTERNAL_captureMetric({ type: 'counter', name: `metric.${i}`, value: i }, { scope });
}

expect(_INTERNAL_getMetricBuffer(client)).toHaveLength(100);
expect(_INTERNAL_getMetricBuffer(client)).toHaveLength(1000);

// Add one more to trigger flush
_INTERNAL_captureMetric({ type: 'counter', name: 'trigger.flush', value: 999 }, { scope });
Expand Down