fix(tests): un-override nitro dep version for nuxt-3 test #18056
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nitro
2.10was failing our tests due to 500 errors, logs didn't show anything about what was failing but removing the override which then makes it use nitro2.12.9makes the tests pass again.I tried almost all releases from
2.10to2.12.8and they all fail the tests due to timeouts, so only the very last release is the one working, I think we might have a deep dependency causing this, but for now this works for our tests.Nitropack shouldn't even be part of user dependencies as it is determined by the Nuxt version accepted range.