Skip to content

chore(tests): pass test flags through to the test command #18062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

chore(tests): pass test flags through to the test command #18062

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a628d79
chore(e2e): pass test flags through to the test command
logaretm Oct 31, 2025
5b406bc
fix: cmd injection issue
logaretm Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 34 additions & 9 deletions dev-packages/e2e-tests/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,38 @@ const DEFAULT_DSN = 'https://username@domain/123';
const DEFAULT_SENTRY_ORG_SLUG = 'sentry-javascript-sdks';
const DEFAULT_SENTRY_PROJECT = 'sentry-javascript-e2e-tests';

function asyncExec(command: string, options: { env: Record<string, string | undefined>; cwd: string }): Promise<void> {
function asyncExec(
command: string | string[],
options: { env: Record<string, string | undefined>; cwd: string },
): Promise<void> {
return new Promise((resolve, reject) => {
const process = spawn(command, { ...options, shell: true });
// If command is an array, use spawn with separate command and args (safer)
// If command is a string, maintain backward compatibility with shell: true
let process: ReturnType<typeof spawn>;
if (typeof command === 'string') {
process = spawn(command, { ...options, shell: true });
} else {
if (command.length === 0) {
return reject(new Error('Command array cannot be empty'));
}
const cmd = command[0];
if (!cmd) {
return reject(new Error('Command array cannot be empty'));
}
process = spawn(cmd, command.slice(1), { ...options, shell: false });
}

process.stdout.on('data', data => {
console.log(`${data}`);
});
if (process.stdout) {
process.stdout.on('data', data => {
console.log(`${data}`);
});
}

process.stderr.on('data', data => {
console.error(`${data}`);
});
if (process.stderr) {
process.stderr.on('data', data => {
console.error(`${data}`);
});
}

process.on('error', error => {
reject(error);
Expand All @@ -43,6 +64,8 @@ async function run(): Promise<void> {

// Allow to run a single app only via `yarn test:run <app-name>`
const appName = process.argv[2] || '';
// Forward any additional flags to the test command
const testFlags = process.argv.slice(3);

const dsn = process.env.E2E_TEST_DSN || DEFAULT_DSN;

Expand Down Expand Up @@ -87,7 +110,9 @@ async function run(): Promise<void> {
await asyncExec('volta run pnpm test:build', { env, cwd });

console.log(`Testing ${testAppPath}...`);
await asyncExec('volta run pnpm test:assert', { env, cwd });
// Pass command and arguments as an array to prevent command injection
const testCommand = ['volta', 'run', 'pnpm', 'test:assert', ...testFlags];
await asyncExec(testCommand, { env, cwd });
Copy link

@cursor cursor bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Bug

The testCommand directly concatenates user-provided arguments into a shell command string. This introduces a command injection vulnerability, allowing arbitrary command execution, and causes arguments containing spaces or special characters to be parsed incorrectly.

Fix in Cursor Fix in Web


// clean up (although this is tmp, still nice to do)
await rm(tmpDirPath, { recursive: true });
Expand Down
Loading