Skip to content

fix(cloudflare): Ensure types for cloudflare handlers #18064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
+13 −5
Merged

fix(cloudflare): Ensure types for cloudflare handlers #18064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5993694
fix(cloudflare): Ensure types for cloudflare handlers
JPeer264 Oct 29, 2025
a9d7726
fixup! fix(cloudflare): Ensure types for cloudflare handlers
JPeer264 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dev-packages/e2e-tests/test-applications/cloudflare-hono/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-hono/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"cf-typegen": "wrangler types --env-interface CloudflareBindings",
"test:build": "pnpm install && pnpm build",
"//": "Just checking if it builds correctly and types don't break",
"test:assert": "pnpm typecheck"
"test:assert": "pnpm typecheck && vitest run ."
},
"dependencies": {
"@sentry/cloudflare": "latest || *",
Expand Down
14 changes: 10 additions & 4 deletions packages/cloudflare/src/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,16 @@ import { copyExecutionContext } from './utils/copyExecutionContext';
* @returns The wrapped handler.
*/
// eslint-disable-next-line complexity
export function withSentry<Env = unknown, QueueHandlerMessage = unknown, CfHostMetadata = unknown>(
optionsCallback: (env: Env) => CloudflareOptions,
handler: ExportedHandler<Env, QueueHandlerMessage, CfHostMetadata>,
): ExportedHandler<Env, QueueHandlerMessage, CfHostMetadata> {
export function withSentry<
Env = unknown,
QueueHandlerMessage = unknown,
CfHostMetadata = unknown,
T extends ExportedHandler<Env, QueueHandlerMessage, CfHostMetadata> = ExportedHandler<
Env,
QueueHandlerMessage,
CfHostMetadata
>,
>(optionsCallback: (env: Env) => CloudflareOptions, handler: T): T {
setAsyncLocalStorageAsyncContextStrategy();

try {
Expand Down