Skip to content

fix(v9/e2e-tests): Fix various e2e tests #18226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2025
+8 −8
Merged

fix(v9/e2e-tests): Fix various e2e tests #18226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a616af5
fix(v9/e2e-tests): Fix various e2e tests
s1gr1d Oct 21, 2025
cb3c321
Pin E2E test app SvelteKit versions and fix failing tests
andreiborza Nov 17, 2025
d06ecb4
Remove nitro override in nuxt-3-min
andreiborza Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dev-packages/e2e-tests/test-applications/ember-classic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
"node": ">=18"
},
"resolutions": {
"@babel/traverse": "~7.25.9"
"@babel/traverse": "~7.25.9",
"clean-css": "^5.3.0"
},
"ember": {
"edition": "octane"
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
},
"pnpm": {
"overrides": {
"nitropack": "2.10.0",
"ofetch": "1.4.0",
"@vercel/nft": "0.29.4"
}
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@playwright/test": "~1.53.2",
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.21.3",
"@sveltejs/kit": "2.41.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^5.0.0-next.115",
"svelte-check": "^3.6.0",
Expand Down
8 changes: 4 additions & 4 deletions dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ test.describe('performance events', () => {
'sentry.origin': 'auto.navigation.sveltekit',
'sentry.op': 'navigation',
'sentry.source': 'route',
'sentry.sveltekit.navigation.type': 'goto',
'sentry.sveltekit.navigation.type': 'link',
'sentry.sveltekit.navigation.from': '/',
Comment on lines +319 to 320
Copy link

@sentry sentry bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: PR assumes navigation.type changes from 'goto' to 'link' for redirects in SvelteKit 2.41.0 without evidence.
Severity: HIGH | Confidence: 0.90

🔍 Detailed Analysis

The pull request modifies test expectations for navigation.type in the sveltekit-2-svelte-5 e2e tests, assuming that upgrading @sveltejs/kit from ^2.21.3 to 2.41.0 will change redirect navigation types from 'goto' to 'link'. This assumption lacks evidence (no changelog, issue, or documentation reference) and creates an inconsistency with the sveltekit-2 test suite, which expects 'goto' for the same redirect navigations. If SvelteKit 2.41.0 does not change this behavior, the updated tests will fail, as programmatic redirects are documented to be 'goto'.

💡 Suggested Fix

Verify if SvelteKit 2.41.0 actually changes navigation.type for redirects from 'goto' to 'link'. Adjust test expectations accordingly or revert if no change is confirmed.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location:
dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts#L319-L320

Potential issue: The pull request modifies test expectations for `navigation.type` in
the `sveltekit-2-svelte-5` e2e tests, assuming that upgrading `@sveltejs/kit` from
`^2.21.3` to `2.41.0` will change redirect navigation types from `'goto'` to `'link'`.
This assumption lacks evidence (no changelog, issue, or documentation reference) and
creates an inconsistency with the `sveltekit-2` test suite, which expects `'goto'` for
the same redirect navigations. If SvelteKit 2.41.0 does not change this behavior, the
updated tests will fail, as programmatic redirects are documented to be `'goto'`.

Did we get this right? 👍 / 👎 to inform future reviews.

Reference_id: 2721742

Copy link
Member Author

@andreiborza andreiborza Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant.

'sentry.sveltekit.navigation.to': '/redirect2',
'sentry.sample_rate': 1,
Expand All @@ -337,7 +337,7 @@ test.describe('performance events', () => {
'sentry.origin': 'auto.ui.sveltekit',
'sentry.sveltekit.navigation.from': '/',
'sentry.sveltekit.navigation.to': '/redirect2',
'sentry.sveltekit.navigation.type': 'goto',
'sentry.sveltekit.navigation.type': 'link',
},
});

Expand All @@ -353,7 +353,7 @@ test.describe('performance events', () => {
'sentry.origin': 'auto.navigation.sveltekit',
'sentry.op': 'navigation',
'sentry.source': 'route',
'sentry.sveltekit.navigation.type': 'goto',
'sentry.sveltekit.navigation.type': 'link',
'sentry.sveltekit.navigation.from': '/',
'sentry.sveltekit.navigation.to': '/users/[id]',
'sentry.sample_rate': 1,
Expand All @@ -374,7 +374,7 @@ test.describe('performance events', () => {
'sentry.origin': 'auto.ui.sveltekit',
'sentry.sveltekit.navigation.from': '/',
'sentry.sveltekit.navigation.to': '/users/[id]',
'sentry.sveltekit.navigation.type': 'goto',
'sentry.sveltekit.navigation.type': 'link',
},
});
});
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/sveltekit-2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/adapter-node": "^2.0.0",
"@sveltejs/kit": "^2.21.3",
"@sveltejs/kit": "2.21.3",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"svelte-check": "^3.6.0",
Expand Down
Loading